From 061af28c485523596caf14eb9bb35c3afa96e037 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sat, 7 Feb 2026 17:07:53 +0100
Subject: [PATCH] Fixed phpstan issues in GenericWebProvider

---
 phpstan.dist.neon                                        | 3 +++
 .../InfoProviderSystem/Providers/GenericWebProvider.php  | 9 +++------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/phpstan.dist.neon b/phpstan.dist.neon
index eb629314..b03c20c2 100644
--- a/phpstan.dist.neon
+++ b/phpstan.dist.neon
@@ -67,3 +67,6 @@ parameters:
         -
             message: '#Should not use function "shell_exec"#'
             path: src/Services/System/UpdateExecutor.php
+
+        - message: '#Access to an undefined property Brick\\Schema\\Interfaces\\#'
+          path: src/Services/InfoProviderSystem/Providers/GenericWebProvider.php
diff --git a/src/Services/InfoProviderSystem/Providers/GenericWebProvider.php b/src/Services/InfoProviderSystem/Providers/GenericWebProvider.php
index 6d27beb2..7fbf5a58 100644
--- a/src/Services/InfoProviderSystem/Providers/GenericWebProvider.php
+++ b/src/Services/InfoProviderSystem/Providers/GenericWebProvider.php
@@ -213,14 +213,14 @@ class GenericWebProvider implements InfoProviderInterface
 
         //Try to extract weight
         $mass = null;
-        if (($weight = $product?->weight->getFirstValue()) instanceof QuantitativeValue) {
+        if (($weight = $product->weight?->getFirstValue()) instanceof QuantitativeValue) {
             $mass = $weight->value->toString();
         }
 
         return new PartDetailDTO(
             provider_key: $this->getProviderKey(),
             provider_id: $url,
-            name: $product->name?->toString() ?? $product->alternateName?->toString() ?? $product?->mpn->toString() ?? 'Unknown Name',
+            name: $product->name?->toString() ?? $product->alternateName?->toString() ?? $product->mpn?->toString() ?? 'Unknown Name',
             description: $this->getMetaContent($dom, 'og:description') ?? $this->getMetaContent($dom, 'description') ?? '',
             category: $this->breadcrumbToCategory($categoryBreadcrumb) ?? $product->category?->toString(),
             manufacturer: self::propertyOrString($product->manufacturer) ?? self::propertyOrString($product->brand),
@@ -247,10 +247,7 @@ class GenericWebProvider implements InfoProviderInterface
             return $value;
         }
 
-        if ($value instanceof Thing) {
-            return $value->$property?->toString();
-        }
-        return null;
+        return $value->$property?->toString();
     }