groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2026-03-09 16:59:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Correctly denormalize parent-child relationships in import, when only children not parent fields are given

Browse source 
This fixes issue #1272
This commit is contained in:
Jan Böhmer 2026-03-07 21:08:32 +01:00
parent b8d1414403
commit 12a760d27e
3 changed files with 81 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

37
tests/Serializer/StructuralElementDenormalizerTest.php
View file

@ -85,4 +85,41 @@ final class StructuralElementDenormalizerTest extends WebTestCase
$result2 = $this->service->denormalize($data, Category::class, 'json', ['groups' => ['import']]);
$this->assertSame($result, $result2);
}
public function testDenormalizeViaChildren(): void
{
$data = ['name' => 'Node',
'children' => [
['name' => 'A', 'children' => [['name' => '1'], ['name' => '2']]],
['name' => 'B', 'children' => [['name' => '1'], ['name' => '2']]],
['name' => 'C', 'children' => [['name' => '1'], ['name' => '2'], ['name' => '3']]],
]
];
$result = $this->service->denormalize($data, Category::class, 'json', ['groups' => ['import', 'include_children']]);
$this->assertInstanceOf(Category::class, $result);
$this->assertCount(3, $result->getChildren());
$this->assertSame('A', $result->getChildren()[0]->getName());
$this->assertSame('B', $result->getChildren()[1]->getName());
$this->assertSame('C', $result->getChildren()[2]->getName());
//Parents should be set correctly
$this->assertSame($result, $result->getChildren()[0]->getParent());
$this->assertSame($result, $result->getChildren()[1]->getParent());
$this->assertSame($result, $result->getChildren()[2]->getParent());
$this->assertCount(2, $result->getChildren()[0]->getChildren());
$this->assertSame('1', $result->getChildren()[0]->getChildren()[0]->getName());
$this->assertSame('2', $result->getChildren()[0]->getChildren()[1]->getName());
//Parents should be set correctly
$this->assertSame($result->getChildren()[0], $result->getChildren()[0]->getChildren()[0]->getParent());
$this->assertSame($result->getChildren()[0], $result->getChildren()[0]->getChildren()[1]->getParent());
$this->assertCount(2, $result->getChildren()[1]->getChildren());
$this->assertSame('1', $result->getChildren()[1]->getChildren()[0]->getName());
$this->assertSame('2', $result->getChildren()[1]->getChildren()[1]->getName());
//Must be different instances than the children of A, because we create new elements for the same path, if we don't have them in the DB
$this->assertNotSame($result->getChildren()[0]->getChildren()[0], $result->getChildren()[1]->getChildren()[0]);
}
}