Use a cryptographically random suffix for attachment file names to make them harder guess

2026-02-25 10:59:35 +00:00 · 2026-02-24 23:20:09 +01:00 · 2026-02-24 23:20:09 +01:00 · 1650ade338
commit 1650ade338
parent 0c83fd4799
1 changed files with 4 additions and 1 deletions
--- a/src/Services/Attachments/AttachmentSubmitHandler.php
+++ b/src/Services/Attachments/AttachmentSubmitHandler.php
@ -137,7 +137,10 @@ class AttachmentSubmitHandler
            $attachment->getName()
        );

-        return $safeName.'-'.uniqid('', false).'.'.$extension;
+        // Generate a 12-character URL-safe random string, which should avoid collisions and prevent from guessing file paths.
+        $random = str_replace(['+', '/', '='], ['0', '1', '2'], base64_encode(random_bytes(9)));
+
+        return $safeName.'-'.$random.'.'.$extension;
    }

    /**