From 211d80adee64ad036819659ee5843e8de500bbe9 Mon Sep 17 00:00:00 2001
From: Marc <mkne@users.noreply.github.com>
Date: Sun, 28 Dec 2025 13:52:44 +0000
Subject: [PATCH] Label generator: increase PDF preview height to show toolbar
 in Chromium (fixes #1165)

---
 templates/label_system/dialog.html.twig    |  5 +++--
 tests/Template/LabelDialogTemplateTest.php | 16 ++++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 tests/Template/LabelDialogTemplateTest.php

diff --git a/templates/label_system/dialog.html.twig b/templates/label_system/dialog.html.twig
index b9149aa3..c8af5140 100644
--- a/templates/label_system/dialog.html.twig
+++ b/templates/label_system/dialog.html.twig
@@ -135,8 +135,9 @@
 
 {% block additional_content %}
     {% if pdf_data %}
-        <div class="card mt-2 p-1 border-secondary" style="resize: vertical; overflow: scroll; height: 250px">
-            <object id="pdf_preview"  data="{{ pdf_data | data_uri(mime='application/pdf') }}"style="height: inherit">
+        {# Make the PDF viewer a few pixels taller so Chromium-based browsers show the PDF toolbar by default (fixes #1165) #}
+        <div class="card mt-2 p-1 border-secondary" style="resize: vertical; overflow: auto; height: 280px; min-height: 200px;">
+            <object id="pdf_preview" data="{{ pdf_data | data_uri(mime='application/pdf') }}" style="height: 100%; width: 100%; display: block;">
             </object>
         </div>
     {% endif %}
diff --git a/tests/Template/LabelDialogTemplateTest.php b/tests/Template/LabelDialogTemplateTest.php
new file mode 100644
index 00000000..35c028e9
--- /dev/null
+++ b/tests/Template/LabelDialogTemplateTest.php
@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace App\Tests\Template;
+
+use PHPUnit\Framework\TestCase;
+
+final class LabelDialogTemplateTest extends TestCase
+{
+    public function testPdfViewerHeightIsIncreased(): void
+    {
+        $tpl = file_get_contents(__DIR__ . '/../../templates/label_system/dialog.html.twig');
+
+        $this->assertStringContainsString('id="pdf_preview"', $tpl, 'PDF object id must exist');
+        $this->assertStringContainsString('height: 280px', $tpl, 'Default PDF viewer height should be 280px to make the toolbar visible in Chromium-based browsers');
+    }
+}