From 3431320d03c1521965ece8740ecc141176794a35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Mon, 11 May 2026 23:25:21 +0200
Subject: [PATCH] Fixed potential bugs

---
 src/Services/Attachments/AttachmentManager.php                | 4 ++--
 src/Services/Formatters/SIFormatter.php                       | 4 ++--
 .../PartKeeprImporter/PKImportHelperTrait.php                 | 2 +-
 src/Services/System/GitVersionInfoProvider.php                | 3 +++
 4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/Services/Attachments/AttachmentManager.php b/src/Services/Attachments/AttachmentManager.php
index 1075141b..c661b0f4 100644
--- a/src/Services/Attachments/AttachmentManager.php
+++ b/src/Services/Attachments/AttachmentManager.php
@@ -156,8 +156,8 @@ class AttachmentManager
         //Taken from: https://www.php.net/manual/de/function.filesize.php#106569 and slightly modified
 
         $sz = 'BKMGTP';
-        $factor = (int) floor((strlen((string) $bytes) - 1) / 3);
+        $factor = min((int) floor((strlen((string) $bytes) - 1) / 3), strlen($sz) - 1);
         //Use real (10 based) SI prefixes
-        return sprintf("%.{$decimals}f", $bytes / 1000 ** $factor).@$sz[$factor];
+        return sprintf("%.{$decimals}f", $bytes / 1000 ** $factor).$sz[$factor];
     }
 }
diff --git a/src/Services/Formatters/SIFormatter.php b/src/Services/Formatters/SIFormatter.php
index b83501fa..1f25dbe6 100644
--- a/src/Services/Formatters/SIFormatter.php
+++ b/src/Services/Formatters/SIFormatter.php
@@ -59,10 +59,10 @@ class SIFormatter
         $prefixes_neg = ['', 'm', 'μ', 'n', 'p', 'f', 'a', 'z', 'y'];
 
         if ($magnitude >= 0) {
-            $nearest = (int) floor(abs($magnitude) / 3);
+            $nearest = min((int) floor(abs($magnitude) / 3), count($prefixes_pos) - 1);
             $symbol = $prefixes_pos[$nearest];
         } else {
-            $nearest = (int) round(abs($magnitude) / 3);
+            $nearest = min((int) round(abs($magnitude) / 3), count($prefixes_neg) - 1);
             $symbol = $prefixes_neg[$nearest];
         }
 
diff --git a/src/Services/ImportExportSystem/PartKeeprImporter/PKImportHelperTrait.php b/src/Services/ImportExportSystem/PartKeeprImporter/PKImportHelperTrait.php
index 64127341..08b1c301 100644
--- a/src/Services/ImportExportSystem/PartKeeprImporter/PKImportHelperTrait.php
+++ b/src/Services/ImportExportSystem/PartKeeprImporter/PKImportHelperTrait.php
@@ -89,7 +89,7 @@ trait PKImportHelperTrait
             //Use mime type to determine the extension like PartKeepr does in legacy implementation (just use the second part of the mime type)
             //See UploadedFile.php:291 in PartKeepr (https://github.com/partkeepr/PartKeepr/blob/f6176c3354b24fa39ac8bc4328ee0df91de3d5b6/src/PartKeepr/UploadedFileBundle/Entity/UploadedFile.php#L291)
             if (!empty ($attachment_row['mimetype'])) {
-                $attachment_row['extension'] = explode('/', (string) $attachment_row['mimetype'])[1];
+                $attachment_row['extension'] = explode('/', (string) $attachment_row['mimetype'])[1] ?? '';
             } else {
                 //If the mime type is empty, we use the original extension
                 $attachment_row['extension'] = pathinfo((string) $attachment_row['originalname'], PATHINFO_EXTENSION);
diff --git a/src/Services/System/GitVersionInfoProvider.php b/src/Services/System/GitVersionInfoProvider.php
index 01925ff8..927326e5 100644
--- a/src/Services/System/GitVersionInfoProvider.php
+++ b/src/Services/System/GitVersionInfoProvider.php
@@ -62,6 +62,9 @@ final readonly class GitVersionInfoProvider
     {
         if (is_file($this->getGitDirectory() . '/HEAD')) {
             $git = file($this->getGitDirectory() . '/HEAD');
+            if ($git === false) {
+                return null;
+            }
             $head = explode('/', $git[0], 3);
 
             if (!isset($head[2])) {