groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2026-05-22 19:31:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Preparations for bulk editing of tags

Browse source 
Made "target" parameter of handleAction in parts table a string
Sanitize input for exisitng action which expect an int
Add tag (dummy) to SelectAPI
Add tag option to twig template
This commit is contained in:
d-buchmann 2025-05-22 14:43:05 +02:00
parent b8d5b83eee
commit 334a37a9d0
4 changed files with 40 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/Services/Parts/PartsTableActionHandler.php
View file

@ -67,8 +67,15 @@ final class PartsTableActionHandler
* @return RedirectResponse|null Returns a redirect response if the user should be redirected to another page, otherwise null
* //@param-out list<array{'part': Part, 'message': string|TranslatableInterface}>|array<void> $errors
*/
public function handleAction(string $action, array $selected_parts, ?int $target_id, ?string $redirect_url = null, array &$errors = []): ?RedirectResponse
public function handleAction(string $action, array $selected_parts, ?string $target_id, ?string $redirect_url = null, array &$errors = []): ?RedirectResponse
{
// sanitize target_id
if (!str_contains($action, 'tag') && $target_id !== null)
{
if (!is_numeric($target_id)
throw new InvalidArgumentException('$target_id must be an integer for action'. $action.'!');
}
if ($action === 'add_to_project') {
return new RedirectResponse(
$this->urlGenerator->generate('project_add_parts', [
@ -130,6 +137,18 @@ implode(',', array_map(static fn (PartLot $lot) => $lot->getID(), $part->getPart
$this->denyAccessUnlessGranted('edit', $part);
switch ($action) {
case "add_tag":
$this->denyAccessUnlessGranted('edit', $part);
$tags = $part->getTags();
$part->setTags($tags . ',' . $target_id); // simple append
break;
case "remove_tag":
$this->denyAccessUnlessGranted('edit', $part);
$tags = $part->getTags();
$tags = str_replace($target_id, '', $tags);
// sanitize $tags (remove leading, trailing and double commas)
$part->setTags($tags);
break;
case 'favorite':
$this->denyAccessUnlessGranted('change_favorite', $part);
$part->setFavorite(true);