From 41ae9b5f75ce4c2532da7d735b2ff569c1f2b7d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sat, 22 Feb 2025 17:15:37 +0100
Subject: [PATCH] Added a link to view external version from attachment edit

---
 templates/parts/edit/edit_form_styles.html.twig  |  9 ++++++++-
 templates/parts/info/_attachments_info.html.twig |  2 +-
 translations/messages.en.xlf                     | 12 ++++++++++++
 3 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/templates/parts/edit/edit_form_styles.html.twig b/templates/parts/edit/edit_form_styles.html.twig
index 609e4081..062122de 100644
--- a/templates/parts/edit/edit_form_styles.html.twig
+++ b/templates/parts/edit/edit_form_styles.html.twig
@@ -152,9 +152,10 @@
             </button>
 
             {% set attach = form.vars.value %}
+            {# @var \App\Entity\Attachments\Attachment attach #}
 
             {% if attach is not null %}
-                {% if not attach.hasInternal() %}
+                {% if not attach.hasInternal() and attach.external %}
                     <div class="mt-2">
                         <span class="badge bg-primary">
                             <i class="fas fa-fw fa-globe"></i> {% trans %}attachment.external_only{% endtrans %}
@@ -194,7 +195,13 @@
                         <i class="fas fa-exclamation-circle fa-fw"></i> {% trans %}attachment.file_not_found{% endtrans %}
                     </span>
                     </div>
+                {% endif %}
 
+                {% if attach.external %}
+                    <div>
+                        <a href="{{ attach.externalPath }}" rel="noopener" target="_blank" data-turbo="false" class="link-external"
+                           title="{% trans with {"%host%": attach.host} %}attachment.view_external.view_at{% endtrans %}">{% trans %}attachment.view_external{% endtrans %}</a>
+                    </div>
                 {% endif %}
             {% endif %}
 
diff --git a/templates/parts/info/_attachments_info.html.twig b/templates/parts/info/_attachments_info.html.twig
index 58abdfd8..4f7c0455 100644
--- a/templates/parts/info/_attachments_info.html.twig
+++ b/templates/parts/info/_attachments_info.html.twig
@@ -58,7 +58,7 @@
             <td><div class="btn-group" role="group" aria-label="">
                     <a {% if attachment.hasExternal() %}href="{{ attachment.externalPath }}"{% endif %} target="_blank"
                        class="btn btn-secondary {% if not attachment.hasExternal()  %}disabled{% endif %}"
-                       data-turbo="false" title="View at {{ attachment.host }}" rel="noopener"> {# TODO: translate #}
+                       data-turbo="false" title="{% trans with {"%host%": attachment.host} %}attachment.view_external.view_at{% endtrans %}" rel="noopener">
                         <i class="fas fa-globe fa-fw"></i>
                     </a>
                     <a {% if attachment_manager.isInternalFileExisting(attachment) %}href="{{ entity_url(attachment, 'file_view') }}"{% endif %} target="_blank"
diff --git a/translations/messages.en.xlf b/translations/messages.en.xlf
index e3c435bc..41388de3 100644
--- a/translations/messages.en.xlf
+++ b/translations/messages.en.xlf
@@ -12333,5 +12333,17 @@ Please note, that you can not impersonate a disabled user. If you try you will g
         <target>External link</target>
       </segment>
     </unit>
+    <unit id="2WKNZAm" name="attachment.view_external.view_at">
+      <segment>
+        <source>attachment.view_external.view_at</source>
+        <target>View at %host%</target>
+      </segment>
+    </unit>
+    <unit id="nwO78O_" name="attachment.view_external">
+      <segment>
+        <source>attachment.view_external</source>
+        <target>View external version</target>
+      </segment>
+    </unit>
   </file>
 </xliff>