From 6bc1808fd61f058eda5ca147c6198d54773ed3ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Mon, 9 Sep 2024 00:03:53 +0200 Subject: [PATCH] Use the parameter name $id from interface declaration for getDetails to avoid problems with named arguments --- .../InfoProviderSystem/Providers/OEMSecretsProvider.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php b/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php index 2581168a..1da5b30c 100644 --- a/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php +++ b/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php @@ -412,21 +412,21 @@ class OEMSecretsProvider implements InfoProviderInterface * found in the cache, they are returned. If not, an exception is thrown indicating that * the details could not be found. * - * @param string $provider_id The unique identifier of the provider or part. + * @param string $id The unique identifier of the provider or part. * @return PartDetailDTO The detailed information about the part. * * @throws \Exception If no details are found for the given provider ID. */ - public function getDetails(string $provider_id): PartDetailDTO + public function getDetails(string $id): PartDetailDTO { - $cacheKey = $this->getCacheKey($provider_id); + $cacheKey = $this->getCacheKey($id); $cacheItem = $this->partInfoCache->getItem($cacheKey); if ($cacheItem->isHit()) { $details = $cacheItem->get(); } else { // If the details are not found in the cache, throw an exception - throw new \Exception("Details not found for provider_id $provider_id"); + throw new \Exception("Details not found for provider_id $id"); } return $details;