From 76584c3d991f87265fadb53377bf3b716b520f3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sat, 21 Feb 2026 22:52:08 +0100
Subject: [PATCH] Use native request functions for request param parsing

---
 src/Controller/ScanController.php | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/src/Controller/ScanController.php b/src/Controller/ScanController.php
index a39d9253..94c16b0b 100644
--- a/src/Controller/ScanController.php
+++ b/src/Controller/ScanController.php
@@ -308,21 +308,14 @@ class ScanController extends AbstractController
     {
         $this->denyAccessUnlessGranted('@tools.label_scanner');
 
-        $input = trim((string) $request->request->get('input', ''));
-        $mode  = (string) ($request->request->get('mode') ?? '');
-        $infoMode = (bool) filter_var($request->request->get('info_mode', false), FILTER_VALIDATE_BOOL);
+        $input = trim($request->request->getString('input', ''));
+        $modeEnum  = $request->request->getEnum('mode', BarcodeSourceType::class);
+        $infoMode = $request->request->getBoolean('info_mode', false);
 
         if ($input === '') {
             return new JsonResponse(['ok' => false], 200);
         }
 
-        $modeEnum = null;
-        if ($mode !== '') {
-            $i = (int) $mode;
-            $cases = BarcodeSourceType::cases();
-            $modeEnum = $cases[$i] ?? null; // null if out of range
-        }
-
         try {
             $scan = $this->barcodeNormalizer->scanBarcodeContent($input, $modeEnum);
         } catch (InvalidArgumentException) {
@@ -340,7 +333,6 @@ class ScanController extends AbstractController
             $redirectUrl = $this->barcodeParser->getRedirectURL($scan);
             $targetFound = true;
         } catch (EntityNotFoundException) {
-            $targetFound = false;
         }
 
         // Only resolve Part for part-like targets. Storelocation scans should remain null here.