groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2026-06-28 13:31:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removed useless setAccessible() calls

Browse source 
They are noop since 8.1 and we only support 8.2+
This commit is contained in:
Jan Böhmer 2026-06-25 10:54:13 +02:00
parent 5e18ae2874
commit 9d4dabbd20
5 changed files with 2 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/Repository/DBElementRepository.php
View file

@ -158,7 +158,6 @@ class DBElementRepository extends EntityRepository
{ {
$reflection = new ReflectionClass($element::class); $reflection = new ReflectionClass($element::class);
$property = $reflection->getProperty($field); $property = $reflection->getProperty($field);
$property->setAccessible(true);
$property->setValue($element, $new_value); $property->setValue($element, $new_value);
} }
} }

1
src/Services/ImportExportSystem/PartKeeprImporter/PKImportHelperTrait.php
View file

@ -233,7 +233,6 @@ trait PKImportHelperTrait
$reflectionClass = new \ReflectionClass($entity); $reflectionClass = new \ReflectionClass($entity);
$property = $reflectionClass->getProperty('addedDate'); $property = $reflectionClass->getProperty('addedDate');
$property->setAccessible(true);
$property->setValue($entity, $date); $property->setValue($entity, $date);
} }

1
tests/Entity/Attachments/AttachmentTest.php
View file

@ -276,7 +276,6 @@ final class AttachmentTest extends TestCase
{ {
$reflection = new ReflectionClass($object); $reflection = new ReflectionClass($object);
$reflection_property = $reflection->getProperty($property); $reflection_property = $reflection->getProperty($property);
$reflection_property->setAccessible(true);
$reflection_property->setValue($object, $value); $reflection_property->setValue($object, $value);
} }

10
tests/Services/InfoProviderSystem/Providers/BuerklinProviderTest.php
View file

@ -77,7 +77,6 @@ final class BuerklinProviderTest extends TestCase
public function testAttributesToParametersParsesUnitsAndValues(): void public function testAttributesToParametersParsesUnitsAndValues(): void
{ {
$method = new \ReflectionMethod(BuerklinProvider::class, 'attributesToParameters'); $method = new \ReflectionMethod(BuerklinProvider::class, 'attributesToParameters');
$method->setAccessible(true);
$features = [ $features = [
[ [
@ -127,7 +126,6 @@ final class BuerklinProviderTest extends TestCase
public function testComplianceParameters(): void public function testComplianceParameters(): void
{ {
$method = new \ReflectionMethod(BuerklinProvider::class, 'complianceToParameters'); $method = new \ReflectionMethod(BuerklinProvider::class, 'complianceToParameters');
$method->setAccessible(true);
$product = [ $product = [
'labelRoHS' => 'Yes', 'labelRoHS' => 'Yes',
@ -158,7 +156,6 @@ final class BuerklinProviderTest extends TestCase
public function testImageSelectionPrefersZoomAndDeduplicates(): void public function testImageSelectionPrefersZoomAndDeduplicates(): void
{ {
$method = new \ReflectionMethod(BuerklinProvider::class, 'getProductImages'); $method = new \ReflectionMethod(BuerklinProvider::class, 'getProductImages');
$method->setAccessible(true);
$images = [ $images = [
['format' => 'product', 'url' => '/img/a.webp'], ['format' => 'product', 'url' => '/img/a.webp'],
@ -176,7 +173,6 @@ final class BuerklinProviderTest extends TestCase
public function testFootprintExtraction(): void public function testFootprintExtraction(): void
{ {
$method = new \ReflectionMethod(BuerklinProvider::class, 'getPartDetail'); $method = new \ReflectionMethod(BuerklinProvider::class, 'getPartDetail');
$method->setAccessible(true);
$product = [ $product = [
'code' => 'TEST1', 'code' => 'TEST1',
@ -212,7 +208,6 @@ final class BuerklinProviderTest extends TestCase
]; ];
$method = new \ReflectionMethod(BuerklinProvider::class, 'pricesToVendorInfo'); $method = new \ReflectionMethod(BuerklinProvider::class, 'pricesToVendorInfo');
$method->setAccessible(true);
$vendorInfo = $method->invoke($this->provider, 'SKU1', 'https://x', $detailPrice); $vendorInfo = $method->invoke($this->provider, 'SKU1', 'https://x', $detailPrice);
@ -260,7 +255,6 @@ final class BuerklinProviderTest extends TestCase
); );
$method = new \ReflectionMethod(BuerklinProvider::class, 'convertPartDetailToSearchResult'); $method = new \ReflectionMethod(BuerklinProvider::class, 'convertPartDetailToSearchResult');
$method->setAccessible(true);
$dto = $method->invoke($this->provider, $detail); $dto = $method->invoke($this->provider, $detail);
@ -273,13 +267,13 @@ final class BuerklinProviderTest extends TestCase
{ {
$this->assertSame(['buerklin.com'], $this->provider->getHandledDomains()); $this->assertSame(['buerklin.com'], $this->provider->getHandledDomains());
} }
#[DataProvider('buerklinIdFromUrlProvider')] #[DataProvider('buerklinIdFromUrlProvider')]
public function testGetIDFromURLExtractsId(string $url, ?string $expected): void public function testGetIDFromURLExtractsId(string $url, ?string $expected): void
{ {
$this->assertSame($expected, $this->provider->getIDFromURL($url)); $this->assertSame($expected, $this->provider->getIDFromURL($url));
} }
public static function buerklinIdFromUrlProvider(): \Iterator public static function buerklinIdFromUrlProvider(): \Iterator
{ {
yield 'de long path' => [ yield 'de long path' => [

7
tests/Services/InfoProviderSystem/Providers/LCSCProviderTest.php
View file

@ -367,7 +367,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('sanitizeField'); $method = $reflection->getMethod('sanitizeField');
$method->setAccessible(true);
$this->assertNull($method->invokeArgs($this->provider, [null])); $this->assertNull($method->invokeArgs($this->provider, [null]));
$this->assertEquals('Clean text', $method->invokeArgs($this->provider, ['Clean text'])); $this->assertEquals('Clean text', $method->invokeArgs($this->provider, ['Clean text']));
@ -378,7 +377,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('getUsedCurrency'); $method = $reflection->getMethod('getUsedCurrency');
$method->setAccessible(true);
$this->assertEquals('USD', $method->invokeArgs($this->provider, ['US$'])); $this->assertEquals('USD', $method->invokeArgs($this->provider, ['US$']));
$this->assertEquals('USD', $method->invokeArgs($this->provider, ['$'])); $this->assertEquals('USD', $method->invokeArgs($this->provider, ['$']));
@ -391,7 +389,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('getProductShortURL'); $method = $reflection->getMethod('getProductShortURL');
$method->setAccessible(true);
$result = $method->invokeArgs($this->provider, ['C123456']); $result = $method->invokeArgs($this->provider, ['C123456']);
$this->assertEquals('https://www.lcsc.com/product-detail/C123456.html', $result); $this->assertEquals('https://www.lcsc.com/product-detail/C123456.html', $result);
@ -401,7 +398,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('getProductDatasheets'); $method = $reflection->getMethod('getProductDatasheets');
$method->setAccessible(true);
$result = $method->invokeArgs($this->provider, [null]); $result = $method->invokeArgs($this->provider, [null]);
$this->assertIsArray($result); $this->assertIsArray($result);
@ -417,7 +413,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('getProductImages'); $method = $reflection->getMethod('getProductImages');
$method->setAccessible(true);
$result = $method->invokeArgs($this->provider, [null]); $result = $method->invokeArgs($this->provider, [null]);
$this->assertIsArray($result); $this->assertIsArray($result);
@ -434,7 +429,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('attributesToParameters'); $method = $reflection->getMethod('attributesToParameters');
$method->setAccessible(true);
$attributes = [ $attributes = [
['paramNameEn' => 'Resistance', 'paramValueEn' => '1kΩ'], ['paramNameEn' => 'Resistance', 'paramValueEn' => '1kΩ'],
@ -454,7 +448,6 @@ final class LCSCProviderTest extends TestCase
{ {
$reflection = new \ReflectionClass($this->provider); $reflection = new \ReflectionClass($this->provider);
$method = $reflection->getMethod('pricesToVendorInfo'); $method = $reflection->getMethod('pricesToVendorInfo');
$method->setAccessible(true);
$prices = [ $prices = [
['ladder' => 1, 'productPrice' => '0.10', 'currencySymbol' => 'US$'], ['ladder' => 1, 'productPrice' => '0.10', 'currencySymbol' => 'US$'],