From 9f2989444ac8d0af7dd67a0ae8d6cfede07bf0c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sun, 30 Nov 2025 23:37:34 +0100
Subject: [PATCH] Fixed phpstan issues

---
 src/Entity/Parameters/AbstractParameter.php        | 8 ++++----
 src/Form/InfoProviderSystem/ProviderSelectType.php | 4 +---
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/Entity/Parameters/AbstractParameter.php b/src/Entity/Parameters/AbstractParameter.php
index 388745d4..d84e68ad 100644
--- a/src/Entity/Parameters/AbstractParameter.php
+++ b/src/Entity/Parameters/AbstractParameter.php
@@ -124,7 +124,7 @@ abstract class AbstractParameter extends AbstractNamedDBElement implements Uniqu
     /**
      * @var float|null the guaranteed minimum value of this property
      */
-    #[Assert\Type(['float', null])]
+    #[Assert\Type(['float', 'null'])]
     #[Assert\LessThanOrEqual(propertyPath: 'value_typical', message: 'parameters.validator.min_lesser_typical')]
     #[Assert\LessThan(propertyPath: 'value_max', message: 'parameters.validator.min_lesser_max')]
     #[Groups(['full', 'parameter:read', 'parameter:write', 'import'])]
@@ -134,7 +134,7 @@ abstract class AbstractParameter extends AbstractNamedDBElement implements Uniqu
     /**
      * @var float|null the typical value of this property
      */
-    #[Assert\Type([null, 'float'])]
+    #[Assert\Type(['null', 'float'])]
     #[Groups(['full', 'parameter:read', 'parameter:write', 'import'])]
     #[ORM\Column(type: Types::FLOAT, nullable: true)]
     protected ?float $value_typical = null;
@@ -142,7 +142,7 @@ abstract class AbstractParameter extends AbstractNamedDBElement implements Uniqu
     /**
      * @var float|null the maximum value of this property
      */
-    #[Assert\Type(['float', null])]
+    #[Assert\Type(['float', 'null'])]
     #[Assert\GreaterThanOrEqual(propertyPath: 'value_typical', message: 'parameters.validator.max_greater_typical')]
     #[Groups(['full', 'parameter:read', 'parameter:write', 'import'])]
     #[ORM\Column(type: Types::FLOAT, nullable: true)]
@@ -461,7 +461,7 @@ abstract class AbstractParameter extends AbstractNamedDBElement implements Uniqu
 
         return $str;
     }
-    
+
     /**
      * Returns the class of the element that is allowed to be associated with this attachment.
      * @return string
diff --git a/src/Form/InfoProviderSystem/ProviderSelectType.php b/src/Form/InfoProviderSystem/ProviderSelectType.php
index 74a3c28c..bad3edaa 100644
--- a/src/Form/InfoProviderSystem/ProviderSelectType.php
+++ b/src/Form/InfoProviderSystem/ProviderSelectType.php
@@ -72,11 +72,9 @@ class ProviderSelectType extends AbstractType
         $resolver->setDefault('choice_label', function (Options $options){
             if ('object' === $options['input']) {
                 return ChoiceList::label($this, static fn (?InfoProviderInterface $choice) => new StaticMessage($choice?->getProviderInfo()['name']));
-            } else {
-                return static fn ($choice, $key, $value) => new StaticMessage($key);
             }
 
-            return null;
+            return static fn ($choice, $key, $value) => new StaticMessage($key);
         });
         $resolver->setDefault('choice_value', function (Options $options) {
             if ('object' === $options['input']) {