groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-12-06 02:59:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Validate label profiles before creating them via the label controller, so that we do not create duplicate entries

Browse source 
This fixes issue #994
This commit is contained in:
Jan Böhmer 2025-09-06 23:49:14 +02:00
parent ced16620ec
commit a18ec373d2
1 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/Controller/LabelController.php
View file

@ -58,12 +58,15 @@ use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Attribute\Route; use Symfony\Component\Routing\Attribute\Route;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface; use Symfony\Contracts\Translation\TranslatorInterface;
#[Route(path: '/label')] #[Route(path: '/label')]
class LabelController extends AbstractController class LabelController extends AbstractController
{ {
public function __construct(protected LabelGenerator $labelGenerator, protected EntityManagerInterface $em, protected ElementTypeNameGenerator $elementTypeNameGenerator, protected RangeParser $rangeParser, protected TranslatorInterface $translator) public function __construct(protected LabelGenerator $labelGenerator, protected EntityManagerInterface $em, protected ElementTypeNameGenerator $elementTypeNameGenerator, protected RangeParser $rangeParser, protected TranslatorInterface $translator,
private readonly ValidatorInterface $validator
)
{ {
} }
@ -120,15 +123,25 @@ class LabelController extends AbstractController
goto render; goto render;
} }
$profile = new LabelProfile(); $new_profile = new LabelProfile();
$profile->setName($form->get('save_profile_name')->getData()); $new_profile->setName($form->get('save_profile_name')->getData());
$profile->setOptions($form_options); $new_profile->setOptions($form_options);
$this->em->persist($profile);
//Validate the profile name
$errors = $this->validator->validate($new_profile);
if (count($errors) > 0) {
foreach ($errors as $error) {
$form->get('save_profile_name')->addError(new FormError($error->getMessage()));
}
goto render;
}
$this->em->persist($new_profile);
$this->em->flush(); $this->em->flush();
$this->addFlash('success', 'label_generator.profile_saved'); $this->addFlash('success', 'label_generator.profile_saved');
return $this->redirectToRoute('label_dialog_profile', [ return $this->redirectToRoute('label_dialog_profile', [
'profile' => $profile->getID(), 'profile' => $new_profile->getID(),
'target_id' => (string) $form->get('target_id')->getData() 'target_id' => (string) $form->get('target_id')->getData()
]); ]);
} }