Fixed tests
Some checks failed
Build assets artifact / Build assets artifact (push) Has been cancelled
Docker Image Build / build (linux/amd64, amd64, ubuntu-latest) (push) Has been cancelled
Docker Image Build / build (linux/arm/v7, armv7, ubuntu-24.04-arm) (push) Has been cancelled
Docker Image Build / build (linux/arm64, arm64, ubuntu-24.04-arm) (push) Has been cancelled
Docker Image Build (FrankenPHP) / build (linux/amd64, amd64, ubuntu-latest) (push) Has been cancelled
Docker Image Build (FrankenPHP) / build (linux/arm/v7, armv7, ubuntu-24.04-arm) (push) Has been cancelled
Docker Image Build (FrankenPHP) / build (linux/arm64, arm64, ubuntu-24.04-arm) (push) Has been cancelled
Static analysis / Static analysis (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, mysql) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, mysql) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, mysql) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.5, mysql) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, postgres) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, postgres) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, postgres) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.5, postgres) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, sqlite) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, sqlite) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, sqlite) (push) Has been cancelled
PHPUnit Tests / PHPUnit and coverage Test (PHP 8.5, sqlite) (push) Has been cancelled
Docker Image Build / merge (push) Has been cancelled
Docker Image Build (FrankenPHP) / merge (push) Has been cancelled

This commit is contained in:
Jan Böhmer 2026-02-22 23:50:32 +01:00
parent 430a564592
commit a67f106bc6
2 changed files with 5 additions and 7 deletions

View file

@ -87,7 +87,7 @@ class CanopySettings
*/ */
public function getRealDomain(): string public function getRealDomain(): string
{ {
$domain = array_search($this->domain, self::ALLOWED_DOMAINS); $domain = array_search($this->domain, self::ALLOWED_DOMAINS, true);
if ($domain === false) { if ($domain === false) {
throw new \InvalidArgumentException("Invalid domain selected"); throw new \InvalidArgumentException("Invalid domain selected");
} }

View file

@ -92,7 +92,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
$this->assertNull($url); $this->assertNull($url);
} }
public function testGetRedirectURLThrowsOnUnknownScanType(): void public function testGetRedirectURLReturnsNullOnUnknownScanType(): void
{ {
$unknown = new class implements BarcodeScanResultInterface { $unknown = new class implements BarcodeScanResultInterface {
public function getDecodedForInfoMode(): array public function getDecodedForInfoMode(): array
@ -101,8 +101,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
} }
}; };
$this->expectException(InvalidArgumentException::class); $this->assertNull($this->service->getInfoURL($unknown));
$this->service->getInfoURL($unknown);
} }
public function testEIGPBarcodeResolvePartOrNullReturnsNullWhenNotFound(): void public function testEIGPBarcodeResolvePartOrNullReturnsNullWhenNotFound(): void
@ -124,7 +123,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
$this->assertNull($this->service->getInfoURL($scan)); $this->assertNull($this->service->getInfoURL($scan));
} }
public function testResolveEntityThrowsOnUnknownScanType(): void public function testResolveEntityReturnNullOnUnknownScanType(): void
{ {
$unknown = new class implements BarcodeScanResultInterface { $unknown = new class implements BarcodeScanResultInterface {
public function getDecodedForInfoMode(): array public function getDecodedForInfoMode(): array
@ -133,8 +132,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
} }
}; };
$this->expectException(InvalidArgumentException::class); $this->assertNull($this->service->resolvePart($unknown));
$this->service->resolvePart($unknown);
} }
public function testResolveEntity(): void public function testResolveEntity(): void