groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2026-08-03 23:21:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge 5fa167b944 into 86fcafe47d

Browse source
This commit is contained in:
d-buchmann 2026-08-02 13:28:20 +02:00 • committed by GitHub
commit d2d3b9c4dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/Services/InfoProviderSystem/DTOs/ParameterDTO.php
View file

@ -94,6 +94,13 @@ readonly class ParameterDTO
//If both parts have the same unit and both values are numerical, we'll save it as range
if ($unit === $unit2 && is_numeric($number) && is_numeric($number2)) {
//If the parameter contains AWG in name or unit and min/max order is "wrong", swap it
if (preg_match('/AWG/', $name . $unit) === 1 && $number > $number2) {
$tmp = $number;
$number = $number2;
$number2 = $tmp;
}
return new self(name: $name, value_text: $value_text2, value_min: (float) $number,
value_max: (float) $number2, unit: $unit, symbol: $symbol, group: $group);
}

10
tests/Services/InfoProviderSystem/DTOs/ParameterDTOTest.php
View file

@ -81,6 +81,16 @@ final class ParameterDTOTest extends TestCase
'test'
];
//Test inverse AWG range
yield [
new ParameterDTO('test', value_min: 14, value_max: 22, unit: 'AWG', symbol: 'm', group: 'test'),
'test',
'22..14',
'AWG',
'm',
'test'
];
//Test ranges with tilde
yield [
new ParameterDTO('test', value_min: -1.0, value_max: 2.0, unit: 'kg', symbol: 'm', group: 'test'),