Refactor bulk import functionality to make controller smaller (use services) add DTOs and use stimulus controllers on frontend

assets/controllers/bulk_import_controller.js

@@ -0,0 +1,359 @@
+import { Controller } from "@hotwired/stimulus"
+import { generateCsrfHeaders } from "./csrf_protection_controller"
+
+export default class extends Controller {
+    static targets = ["progressBar", "progressText"]
+    static values = { 
+        jobId: Number,
+        partId: Number,
+        researchUrl: String,
+        researchAllUrl: String,
+        markCompletedUrl: String,
+        markSkippedUrl: String,
+        markPendingUrl: String
+    }
+
+    connect() {
+        // Auto-refresh progress if job is in progress
+        if (this.hasProgressBarTarget) {
+            this.startProgressUpdates()
+        }
+        
+        // Restore scroll position after page reload (if any)
+        this.restoreScrollPosition()
+    }
+
+    getHeaders() {
+        const headers = {
+            'Content-Type': 'application/json',
+            'X-Requested-With': 'XMLHttpRequest'
+        }
+
+        // Add CSRF headers if available
+        const form = document.querySelector('form')
+        if (form) {
+            const csrfHeaders = generateCsrfHeaders(form)
+            Object.assign(headers, csrfHeaders)
+        }
+
+        return headers
+    }
+
+    async fetchWithErrorHandling(url, options = {}, timeout = 30000) {
+        const controller = new AbortController()
+        const timeoutId = setTimeout(() => controller.abort(), timeout)
+        
+        try {
+            const response = await fetch(url, {
+                ...options,
+                headers: { ...this.getHeaders(), ...options.headers },
+                signal: controller.signal
+            })
+
+            clearTimeout(timeoutId)
+
+            if (!response.ok) {
+                const errorText = await response.text()
+                throw new Error(`Server error (${response.status}): ${errorText}`)
+            }
+
+            return await response.json()
+        } catch (error) {
+            clearTimeout(timeoutId)
+            
+            if (error.name === 'AbortError') {
+                throw new Error('Request timed out. Please try again.')
+            } else if (error.message.includes('Failed to fetch')) {
+                throw new Error('Network error. Please check your connection and try again.')
+            } else {
+                throw error
+            }
+        }
+    }
+
+    disconnect() {
+        if (this.progressInterval) {
+            clearInterval(this.progressInterval)
+        }
+    }
+
+    startProgressUpdates() {
+        // Progress updates are handled via page reload for better reliability
+        // No need for periodic updates since state changes trigger page refresh
+    }
+
+    restoreScrollPosition() {
+        const savedPosition = sessionStorage.getItem('bulkImportScrollPosition')
+        if (savedPosition) {
+            // Restore scroll position after a small delay to ensure page is fully loaded
+            setTimeout(() => {
+                window.scrollTo(0, parseInt(savedPosition))
+                // Clear the saved position so it doesn't interfere with normal navigation
+                sessionStorage.removeItem('bulkImportScrollPosition')
+            }, 100)
+        }
+    }
+
+    async markCompleted(event) {
+        const partId = event.currentTarget.dataset.partId
+        
+        try {
+            const url = this.markCompletedUrlValue.replace('__PART_ID__', partId)
+            const data = await this.fetchWithErrorHandling(url, { method: 'POST' })
+            
+            if (data.success) {
+                this.updateProgressDisplay(data)
+                this.markRowAsCompleted(partId)
+                
+                if (data.job_completed) {
+                    this.showJobCompletedMessage()
+                }
+            } else {
+                this.showErrorMessage(data.error || 'Failed to mark part as completed')
+            }
+        } catch (error) {
+            console.error('Error marking part as completed:', error)
+            this.showErrorMessage(error.message || 'Failed to mark part as completed')
+        }
+    }
+
+    async markSkipped(event) {
+        const partId = event.currentTarget.dataset.partId
+        const reason = prompt('Reason for skipping (optional):') || ''
+        
+        try {
+            const url = this.markSkippedUrlValue.replace('__PART_ID__', partId)
+            const data = await this.fetchWithErrorHandling(url, {
+                method: 'POST',
+                body: JSON.stringify({ reason })
+            })
+            
+            if (data.success) {
+                this.updateProgressDisplay(data)
+                this.markRowAsSkipped(partId)
+            } else {
+                this.showErrorMessage(data.error || 'Failed to mark part as skipped')
+            }
+        } catch (error) {
+            console.error('Error marking part as skipped:', error)
+            this.showErrorMessage(error.message || 'Failed to mark part as skipped')
+        }
+    }
+
+    async markPending(event) {
+        const partId = event.currentTarget.dataset.partId
+        
+        try {
+            const url = this.markPendingUrlValue.replace('__PART_ID__', partId)
+            const data = await this.fetchWithErrorHandling(url, { method: 'POST' })
+            
+            if (data.success) {
+                this.updateProgressDisplay(data)
+                this.markRowAsPending(partId)
+            } else {
+                this.showErrorMessage(data.error || 'Failed to mark part as pending')
+            }
+        } catch (error) {
+            console.error('Error marking part as pending:', error)
+            this.showErrorMessage(error.message || 'Failed to mark part as pending')
+        }
+    }
+
+    updateProgressDisplay(data) {
+        if (this.hasProgressBarTarget) {
+            this.progressBarTarget.style.width = `${data.progress}%`
+            this.progressBarTarget.setAttribute('aria-valuenow', data.progress)
+        }
+        
+        if (this.hasProgressTextTarget) {
+            this.progressTextTarget.textContent = `${data.completed_count} / ${data.total_count} completed`
+        }
+    }
+
+    markRowAsCompleted(partId) {
+        // Save scroll position and refresh page to show updated state
+        sessionStorage.setItem('bulkImportScrollPosition', window.scrollY.toString())
+        window.location.reload()
+    }
+
+    markRowAsSkipped(partId) {
+        // Save scroll position and refresh page to show updated state
+        sessionStorage.setItem('bulkImportScrollPosition', window.scrollY.toString())
+        window.location.reload()
+    }
+
+    markRowAsPending(partId) {
+        // Save scroll position and refresh page to show updated state
+        sessionStorage.setItem('bulkImportScrollPosition', window.scrollY.toString())
+        window.location.reload()
+    }
+
+    showJobCompletedMessage() {
+        const alert = document.createElement('div')
+        alert.className = 'alert alert-success alert-dismissible fade show'
+        alert.innerHTML = `
+            <i class="fas fa-check-circle"></i>
+            Job completed! All parts have been processed.
+            <button type="button" class="btn-close" data-bs-dismiss="alert"></button>
+        `
+        
+        const container = document.querySelector('.card-body')
+        container.insertBefore(alert, container.firstChild)
+    }
+
+    async researchPart(event) {
+        event.preventDefault()
+        event.stopPropagation()
+        
+        const partId = event.currentTarget.dataset.partId
+        const spinner = event.currentTarget.querySelector(`[data-research-spinner="${partId}"]`)
+        const button = event.currentTarget
+        
+        // Show loading state
+        if (spinner) {
+            spinner.style.display = 'inline-block'
+        }
+        button.disabled = true
+        
+        try {
+            const url = this.researchUrlValue.replace('__PART_ID__', partId)
+            const controller = new AbortController()
+            const timeoutId = setTimeout(() => controller.abort(), 30000) // 30 second timeout
+            
+            const response = await fetch(url, {
+                method: 'POST',
+                headers: this.getHeaders(),
+                signal: controller.signal
+            })
+
+            clearTimeout(timeoutId)
+
+            if (!response.ok) {
+                const errorText = await response.text()
+                throw new Error(`Server error (${response.status}): ${errorText}`)
+            }
+
+            const data = await response.json()
+            
+            if (data.success) {
+                this.showSuccessMessage(`Research completed for part. Found ${data.results_count} results.`)
+                // Save scroll position and reload to show updated results
+                sessionStorage.setItem('bulkImportScrollPosition', window.scrollY.toString())
+                window.location.reload()
+            } else {
+                this.showErrorMessage(data.error || 'Research failed')
+            }
+        } catch (error) {
+            console.error('Error researching part:', error)
+            
+            if (error.name === 'AbortError') {
+                this.showErrorMessage('Research timed out. Please try again.')
+            } else if (error.message.includes('Failed to fetch')) {
+                this.showErrorMessage('Network error. Please check your connection and try again.')
+            } else {
+                this.showErrorMessage(error.message || 'Research failed due to an unexpected error')
+            }
+        } finally {
+            // Hide loading state
+            if (spinner) {
+                spinner.style.display = 'none'
+            }
+            button.disabled = false
+        }
+    }
+
+    async researchAllParts(event) {
+        event.preventDefault()
+        event.stopPropagation()
+        
+        const spinner = document.getElementById('research-all-spinner')
+        const button = event.currentTarget
+        
+        // Show loading state
+        if (spinner) {
+            spinner.style.display = 'inline-block'
+        }
+        button.disabled = true
+        
+        try {
+            const controller = new AbortController()
+            const timeoutId = setTimeout(() => controller.abort(), 120000) // 2 minute timeout for bulk operations
+            
+            const response = await fetch(this.researchAllUrlValue, {
+                method: 'POST',
+                headers: this.getHeaders(),
+                signal: controller.signal
+            })
+
+            clearTimeout(timeoutId)
+
+            if (!response.ok) {
+                const errorText = await response.text()
+                throw new Error(`Server error (${response.status}): ${errorText}`)
+            }
+
+            const data = await response.json()
+            
+            if (data.success) {
+                this.showSuccessMessage(`Research completed for ${data.researched_count} parts.`)
+                // Save scroll position and reload to show updated results
+                sessionStorage.setItem('bulkImportScrollPosition', window.scrollY.toString())
+                window.location.reload()
+            } else {
+                this.showErrorMessage(data.error || 'Bulk research failed')
+            }
+        } catch (error) {
+            console.error('Error researching all parts:', error)
+            
+            if (error.name === 'AbortError') {
+                this.showErrorMessage('Bulk research timed out. This may happen with large batches. Please try again or process smaller batches.')
+            } else if (error.message.includes('Failed to fetch')) {
+                this.showErrorMessage('Network error. Please check your connection and try again.')
+            } else {
+                this.showErrorMessage(error.message || 'Bulk research failed due to an unexpected error')
+            }
+        } finally {
+            // Hide loading state
+            if (spinner) {
+                spinner.style.display = 'none'
+            }
+            button.disabled = false
+        }
+    }
+
+    showSuccessMessage(message) {
+        this.showToast('success', message)
+    }
+
+    showErrorMessage(message) {
+        this.showToast('error', message)
+    }
+
+    showToast(type, message) {
+        // Create a simple alert that doesn't disrupt layout
+        const alertId = 'alert-' + Date.now()
+        const iconClass = type === 'success' ? 'fa-check-circle' : 'fa-exclamation-triangle'
+        const alertClass = type === 'success' ? 'alert-success' : 'alert-danger'
+        
+        const alertHTML = `
+            <div class="alert ${alertClass} alert-dismissible fade show position-fixed" 
+                 style="top: 20px; right: 20px; z-index: 9999; max-width: 400px;" 
+                 id="${alertId}">
+                <i class="fas ${iconClass} me-2"></i>
+                ${message}
+                <button type="button" class="btn-close" onclick="this.parentElement.remove()" aria-label="Close"></button>
+            </div>
+        `
+        
+        // Add alert to body
+        document.body.insertAdjacentHTML('beforeend', alertHTML)
+        
+        // Auto-remove after 5 seconds
+        setTimeout(() => {
+            const alertElement = document.getElementById(alertId)
+            if (alertElement) {
+                alertElement.remove()
+            }
+        }, 5000)
+    }
+}

assets/controllers/bulk_job_manage_controller.js

@@ -0,0 +1,92 @@
+import { Controller } from "@hotwired/stimulus"
+import { generateCsrfHeaders } from "./csrf_protection_controller"
+
+export default class extends Controller {
+    static values = {
+        deleteUrl: String,
+        stopUrl: String,
+        deleteConfirmMessage: String,
+        stopConfirmMessage: String
+    }
+
+    connect() {
+        // Controller initialized
+    }
+    getHeaders() {
+        const headers = {
+            'X-Requested-With': 'XMLHttpRequest'
+        }
+
+        // Add CSRF headers if available
+        const form = document.querySelector('form')
+        if (form) {
+            const csrfHeaders = generateCsrfHeaders(form)
+            Object.assign(headers, csrfHeaders)
+        }
+
+        return headers
+    }
+    async deleteJob(event) {
+        const jobId = event.currentTarget.dataset.jobId
+        const confirmMessage = this.deleteConfirmMessageValue || 'Are you sure you want to delete this job?'
+        
+        if (confirm(confirmMessage)) {
+            try {
+                const deleteUrl = this.deleteUrlValue.replace('__JOB_ID__', jobId)
+                
+                const response = await fetch(deleteUrl, {
+                    method: 'DELETE',
+                    headers: this.getHeaders()
+                })
+                
+                if (!response.ok) {
+                    const errorText = await response.text()
+                    throw new Error(`HTTP ${response.status}: ${errorText}`)
+                }
+                
+                const data = await response.json()
+                
+                if (data.success) {
+                    location.reload()
+                } else {
+                    alert('Error deleting job: ' + (data.error || 'Unknown error'))
+                }
+            } catch (error) {
+                console.error('Error deleting job:', error)
+                alert('Error deleting job: ' + error.message)
+            }
+        }
+    }
+
+    async stopJob(event) {
+        const jobId = event.currentTarget.dataset.jobId
+        const confirmMessage = this.stopConfirmMessageValue || 'Are you sure you want to stop this job?'
+        
+        if (confirm(confirmMessage)) {
+            try {
+                const stopUrl = this.stopUrlValue.replace('__JOB_ID__', jobId)
+                
+                const response = await fetch(stopUrl, {
+                    method: 'POST',
+                    headers: this.getHeaders()
+                })
+                
+                if (!response.ok) {
+                    const errorText = await response.text()
+                    throw new Error(`HTTP ${response.status}: ${errorText}`)
+                }
+                
+                const data = await response.json()
+                
+                if (data.success) {
+                    location.reload()
+                } else {
+                    alert('Error stopping job: ' + (data.error || 'Unknown error'))
+                }
+            } catch (error) {
+                console.error('Error stopping job:', error)
+                alert('Error stopping job: ' + error.message)
+            }
+        }
+    }
+}

assets/controllers/field_mapping_controller.js

@@ -0,0 +1,138 @@
+import { Controller } from "@hotwired/stimulus"
+
+export default class extends Controller {
+    static targets = ["tbody", "addButton", "submitButton"]
+    static values = { 
+        mappingIndex: Number,
+        maxMappings: Number,
+        prototype: String,
+        maxMappingsReachedMessage: String
+    }
+
+    connect() {
+        this.updateAddButtonState()
+        this.updateFieldOptions()
+        this.attachEventListeners()
+    }
+
+    attachEventListeners() {
+        // Add event listeners to existing field selects
+        const fieldSelects = this.tbodyTarget.querySelectorAll('select[name*="[field]"]')
+        fieldSelects.forEach(select => {
+            select.addEventListener('change', this.updateFieldOptions.bind(this))
+        })
+
+        // Add click listener to add button
+        if (this.hasAddButtonTarget) {
+            this.addButtonTarget.addEventListener('click', this.addMapping.bind(this))
+        }
+
+        // Form submit handler
+        const form = this.element.querySelector('form')
+        if (form && this.hasSubmitButtonTarget) {
+            form.addEventListener('submit', this.handleFormSubmit.bind(this))
+        }
+    }
+
+    addMapping() {
+        const currentMappings = this.tbodyTarget.querySelectorAll('.mapping-row').length
+        
+        if (currentMappings >= this.maxMappingsValue) {
+            alert(this.maxMappingsReachedMessageValue)
+            return
+        }
+        
+        const newRowHtml = this.prototypeValue.replace(/__name__/g, this.mappingIndexValue)
+        const tempDiv = document.createElement('div')
+        tempDiv.innerHTML = newRowHtml
+        
+        const fieldWidget = tempDiv.querySelector('select[name*="[field]"]') || tempDiv.children[0]
+        const providerWidget = tempDiv.querySelector('select[name*="[providers]"]') || tempDiv.children[1]
+        const priorityWidget = tempDiv.querySelector('input[name*="[priority]"]') || tempDiv.children[2]
+        
+        const newRow = document.createElement('tr')
+        newRow.className = 'mapping-row'
+        newRow.innerHTML = `
+            <td>${fieldWidget ? fieldWidget.outerHTML : ''}</td>
+            <td>${providerWidget ? providerWidget.outerHTML : ''}</td>
+            <td>${priorityWidget ? priorityWidget.outerHTML : ''}</td>
+            <td>
+                <button type="button" class="btn btn-danger btn-sm" data-action="click->field-mapping#removeMapping">
+                    <i class="fas fa-trash"></i>
+                </button>
+            </td>
+        `
+        
+        this.tbodyTarget.appendChild(newRow)
+        this.mappingIndexValue++
+        
+        const newFieldSelect = newRow.querySelector('select[name*="[field]"]')
+        if (newFieldSelect) {
+            newFieldSelect.value = ''
+            newFieldSelect.addEventListener('change', this.updateFieldOptions.bind(this))
+        }
+        
+        this.updateFieldOptions()
+        this.updateAddButtonState()
+    }
+
+    removeMapping(event) {
+        const row = event.target.closest('tr')
+        row.remove()
+        this.updateFieldOptions()
+        this.updateAddButtonState()
+    }
+
+    updateFieldOptions() {
+        const fieldSelects = this.tbodyTarget.querySelectorAll('select[name*="[field]"]')
+        
+        const selectedFields = Array.from(fieldSelects)
+            .map(select => select.value)
+            .filter(value => value && value !== '')
+        
+        fieldSelects.forEach(select => {
+            Array.from(select.options).forEach(option => {
+                const isCurrentValue = option.value === select.value
+                const isEmptyOption = !option.value || option.value === ''
+                const isAlreadySelected = selectedFields.includes(option.value)
+                
+                if (!isEmptyOption && isAlreadySelected && !isCurrentValue) {
+                    option.disabled = true
+                    option.style.display = 'none'
+                } else {
+                    option.disabled = false
+                    option.style.display = ''
+                }
+            })
+        })
+    }
+
+    updateAddButtonState() {
+        const currentMappings = this.tbodyTarget.querySelectorAll('.mapping-row').length
+        
+        if (this.hasAddButtonTarget) {
+            if (currentMappings >= this.maxMappingsValue) {
+                this.addButtonTarget.disabled = true
+                this.addButtonTarget.title = this.maxMappingsReachedMessageValue
+            } else {
+                this.addButtonTarget.disabled = false
+                this.addButtonTarget.title = ''
+            }
+        }
+    }
+
+    handleFormSubmit(event) {
+        if (this.hasSubmitButtonTarget) {
+            this.submitButtonTarget.disabled = true
+            
+            // Disable the entire form to prevent changes during processing
+            const form = event.target
+            const formElements = form.querySelectorAll('input, select, textarea, button')
+            formElements.forEach(element => {
+                if (element !== this.submitButtonTarget) {
+                    element.disabled = true
+                }
+            })
+        }
+    }
+}