From e49e2d79765dcb3e732513e6adad3022b7572493 Mon Sep 17 00:00:00 2001
From: Marc Kreidler <kreidler@nedo.com>
Date: Thu, 18 Dec 2025 15:23:21 +0100
Subject: [PATCH] Revert SonarQube proposed change. Having more than one return
 is acceptable nowadays

---
 .../Providers/BuerklinProvider.php            | 39 +++++++++----------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/src/Services/InfoProviderSystem/Providers/BuerklinProvider.php b/src/Services/InfoProviderSystem/Providers/BuerklinProvider.php
index 9dc85b3a..73439672 100644
--- a/src/Services/InfoProviderSystem/Providers/BuerklinProvider.php
+++ b/src/Services/InfoProviderSystem/Providers/BuerklinProvider.php
@@ -465,30 +465,29 @@ class BuerklinProvider implements BatchInfoProviderInterface
     public function searchByKeyword(string $keyword): array
     {
         $keyword = strtoupper(trim($keyword));
-        if (!empty($keyword)) {
+        if ($keyword === '') {
+            return [];
+        }
 
-            $response = $this->makeAPICall('/products/search/', [
-                'pageSize' => 50,
-                'currentPage' => 0,
-                'query' => $keyword,
-                'sort' => 'relevance',
-            ]);
+        $response = $this->makeAPICall('/products/search/', [
+            'pageSize' => 50,
+            'currentPage' => 0,
+            'query' => $keyword,
+            'sort' => 'relevance',
+        ]);
 
-            $products = $response['products'] ?? [];
+        $products = $response['products'] ?? [];
 
-            // Normal case: products found in search results
-            if (is_array($products) && !empty($products)) {
-                return array_map(fn($p) => $this->getPartDetail($p), $products);
-            }
+        // Normal case: products found in search results
+        if (is_array($products) && !empty($products)) {
+            return array_map(fn($p) => $this->getPartDetail($p), $products);
+        }
 
-            // Fallback: try direct lookup by code
-            try {
-                $product = $this->getProduct($keyword);
-                return [$this->getPartDetail($product)];
-            } catch (\Throwable $e) {
-                return [];
-            }
-        } else {
+        // Fallback: try direct lookup by code
+        try {
+            $product = $this->getProduct($keyword);
+            return [$this->getPartDetail($product)];
+        } catch (\Throwable $e) {
             return [];
         }
     }