Made image size of preview images in tables configurable and slightly bigger by default

This makes PR #984 and #623 obsolete
This commit is contained in:
Jan Böhmer 2025-09-07 21:21:08 +02:00
parent 0d1ae030be
commit ecd2abe00e
4 changed files with 38 additions and 4 deletions

View file

@ -18,8 +18,8 @@
*/ */
.hoverpic { .hoverpic {
min-width: 10px; min-width: var(--table-image-preview-min-size, 20px);
max-width: 30px; max-width: var(--table-image-preview-max-size, 35px);
display: block; display: block;
margin-left: auto; margin-left: auto;
margin-right: auto; margin-right: auto;
@ -49,7 +49,7 @@
} }
.part-table-image { .part-table-image {
max-height: 40px; max-height: calc(1.2*var(--table-image-preview-max-size, 35px)); /** Aspect ratio of maximum 1.2 */
object-fit: contain; object-fit: contain;
} }

View file

@ -70,6 +70,20 @@ class TableSettings
PartTableColumns::CATEGORY, PartTableColumns::FOOTPRINT, PartTableColumns::MANUFACTURER, PartTableColumns::CATEGORY, PartTableColumns::FOOTPRINT, PartTableColumns::MANUFACTURER,
PartTableColumns::LOCATION, PartTableColumns::AMOUNT]; PartTableColumns::LOCATION, PartTableColumns::AMOUNT];
#[SettingsParameter(label: new TM("settings.behavior.table.preview_image_min_width"),
formOptions: ['attr' => ['min' => 1, 'max' => 100]],
envVar: "int:TABLE_IMAGE_PREVIEW_MIN_SIZE", envVarMode: EnvVarMode::OVERWRITE
)]
#[Assert\Range(min: 1, max: 100)]
public int $previewImageMinWidth = 20;
#[SettingsParameter(label: new TM("settings.behavior.table.preview_image_max_width"),
formOptions: ['attr' => ['min' => 1, 'max' => 100]],
envVar: "int:TABLE_IMAGE_PREVIEW_MAX_SIZE", envVarMode: EnvVarMode::OVERWRITE
)]
#[Assert\Range(min: 1, max: 100)]
#[Assert\GreaterThanOrEqual(propertyPath: 'previewImageMinWidth')]
public int $previewImageMaxWidth = 35;
public static function mapPartsDefaultColumnsEnv(string $columns): array public static function mapPartsDefaultColumnsEnv(string $columns): array
{ {
@ -87,4 +101,4 @@ class TableSettings
return $ret; return $ret;
} }
} }

View file

@ -53,6 +53,14 @@
{% endif %} {% endif %}
{{ encore_entry_link_tags('app') }} {{ encore_entry_link_tags('app') }}
{% set table_settings = settings_instance('table') %}
<style nonce="{{ csp_nonce('style') }}">
:root {
--table-image-preview-min-size: {{ table_settings.previewImageMinWidth }}px;
--table-image-preview-max-size: {{ table_settings.previewImageMaxWidth }}px;
}
</style>
{% endblock %} {% endblock %}
{% block javascripts %} {% block javascripts %}

View file

@ -13489,5 +13489,17 @@ Please note, that you can not impersonate a disabled user. If you try you will g
<target>These providers will be preselected for searches in part providers.</target> <target>These providers will be preselected for searches in part providers.</target>
</segment> </segment>
</unit> </unit>
<unit id="dv6eslZ" name="settings.behavior.table.preview_image_max_width">
<segment>
<source>settings.behavior.table.preview_image_max_width</source>
<target>Preview image max width (px)</target>
</segment>
</unit>
<unit id="5bOoqEL" name="settings.behavior.table.preview_image_min_width">
<segment>
<source>settings.behavior.table.preview_image_min_width</source>
<target>Preview image min width (px)</target>
</segment>
</unit>
</file> </file>
</xliff> </xliff>