Updated dependencies

Return null instead of throwing an exception that could lead to a denial of service when trying to generate a thumbnail for a non-image picture
2026-04-18 12:29:36 +00:00 · 2025-08-12 23:34:06 +02:00 · 2025-08-12 23:29:24 +02:00
3 changed files with 1372 additions and 1026 deletions
--- a/composer.lock
+++ b/composer.lock
--- a/src/Services/Attachments/AttachmentURLGenerator.php
+++ b/src/Services/Attachments/AttachmentURLGenerator.php
@ -112,12 +112,12 @@ class AttachmentURLGenerator
    /**
     * Returns a URL to a thumbnail of the attachment file.
     * For external files the original URL is returned.
-     * @return string|null The URL or null if the attachment file is not existing
+     * @return string|null The URL or null if the attachment file is not existing or is invalid
     */
    public function getThumbnailURL(Attachment $attachment, string $filter_name = 'thumbnail_sm'): ?string
    {
        if (!$attachment->isPicture()) {
-            throw new InvalidArgumentException('Thumbnail creation only works for picture attachments!');
+            return null;
        }
        if (!$attachment->hasInternal()){
--- a/yarn.lock
+++ b/yarn.lock
Author	SHA1	Message	Date
Jan Böhmer	23cd51c1ca	Updated dependencies Some checks are pending Build assets artifact / Build assets artifact (push) Waiting to run Details Docker Image Build / docker (push) Waiting to run Details Docker Image Build (FrankenPHP) / docker (push) Waiting to run Details Static analysis / Static analysis (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.1, mysql) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, mysql) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, mysql) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, mysql) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.1, postgres) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, postgres) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, postgres) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, postgres) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.1, sqlite) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.2, sqlite) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.3, sqlite) (push) Waiting to run Details PHPUnit Tests / PHPUnit and coverage Test (PHP 8.4, sqlite) (push) Waiting to run Details	2025-08-12 23:34:06 +02:00
Jan Böhmer	d370f976a7	Return null instead of throwing an exception that could lead to a denial of service when trying to generate a thumbnail for a non-image picture	2025-08-12 23:29:24 +02:00