feat: enhance theme management by integrating high contrast support in various components

This commit is contained in:
Dr-Blank 2024-10-05 07:22:00 -04:00
parent 9441a2cdd3
commit 07780ada4e
No known key found for this signature in database
GPG key ID: 7452CC63F210A266
5 changed files with 66 additions and 12 deletions

View file

@ -353,16 +353,17 @@ class _BookCover extends HookConsumerWidget {
final coverImage = ref.watch(coverImageProvider(itemId)); final coverImage = ref.watch(coverImageProvider(itemId));
final themeData = Theme.of(context); final themeData = Theme.of(context);
// final item = ref.watch(libraryItemProvider(itemId)); // final item = ref.watch(libraryItemProvider(itemId));
final useMaterialThemeOnItemPage = final themeSettings = ref.watch(appSettingsProvider).themeSettings;
ref.watch(appSettingsProvider).themeSettings.useMaterialThemeOnItemPage;
ColorScheme? coverColorScheme; ColorScheme? coverColorScheme;
if (useMaterialThemeOnItemPage) { if (themeSettings.useMaterialThemeOnItemPage) {
coverColorScheme = ref coverColorScheme = ref
.watch( .watch(
themeOfLibraryItemProvider( themeOfLibraryItemProvider(
itemId, itemId,
brightness: Theme.of(context).brightness, brightness: Theme.of(context).brightness,
highContrast: MediaQuery.of(context).highContrast ||
themeSettings.highContrast,
), ),
) )
.valueOrNull; .valueOrNull;
@ -371,7 +372,7 @@ class _BookCover extends HookConsumerWidget {
return ThemeSwitcher( return ThemeSwitcher(
builder: (context) { builder: (context) {
// change theme after 2 seconds // change theme after 2 seconds
if (useMaterialThemeOnItemPage) { if (themeSettings.useMaterialThemeOnItemPage) {
Future.delayed(150.ms, () { Future.delayed(150.ms, () {
try { try {
ThemeSwitcher.of(context).changeTheme( ThemeSwitcher.of(context).changeTheme(

View file

@ -65,6 +65,8 @@ class AudiobookPlayer extends HookConsumerWidget {
themeOfLibraryItemProvider( themeOfLibraryItemProvider(
itemBeingPlayed.valueOrNull?.id, itemBeingPlayed.valueOrNull?.id,
brightness: Theme.of(context).brightness, brightness: Theme.of(context).brightness,
highContrast: MediaQuery.of(context).highContrast ||
appSettings.themeSettings.highContrast,
), ),
); );

View file

@ -71,7 +71,7 @@ class MyApp extends ConsumerWidget {
} }
// set the background and surface colors to pure black in the amoled theme // set the background and surface colors to pure black in the amoled theme
if (themeSettings.highContrast) { if (MediaQuery.of(context).highContrast || themeSettings.highContrast) {
lightColorScheme = lightColorScheme =
lightColorScheme.copyWith(surface: Colors.white).harmonized(); lightColorScheme.copyWith(surface: Colors.white).harmonized();
darkColorScheme = darkColorScheme =
@ -86,6 +86,10 @@ class MyApp extends ConsumerWidget {
useMaterial3: true, useMaterial3: true,
colorScheme: darkColorScheme, colorScheme: darkColorScheme,
brightness: Brightness.dark, brightness: Brightness.dark,
// TODO bottom sheet theme is not working
bottomSheetTheme: BottomSheetThemeData(
backgroundColor: darkColorScheme.surface,
),
); );
final themeLightHighContrast = themeLight.copyWith( final themeLightHighContrast = themeLight.copyWith(
colorScheme: colorScheme:

View file

@ -1,3 +1,4 @@
import 'package:dynamic_color/dynamic_color.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter_animate/flutter_animate.dart'; import 'package:flutter_animate/flutter_animate.dart';
import 'package:logging/logging.dart'; import 'package:logging/logging.dart';
@ -13,15 +14,25 @@ Future<FutureOr<ColorScheme?>> themeFromCover(
ThemeFromCoverRef ref, ThemeFromCoverRef ref,
ImageProvider<Object> img, { ImageProvider<Object> img, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) async { }) async {
// ! add deliberate delay to simulate a long running task as it interferes with other animations // ! add deliberate delay to simulate a long running task as it interferes with other animations
await Future.delayed(500.ms); await Future.delayed(500.ms);
_logger.fine('Generating color scheme from cover image'); _logger.fine('Generating color scheme from cover image');
return ColorScheme.fromImageProvider( var theme = await ColorScheme.fromImageProvider(
provider: img, provider: img,
brightness: brightness, brightness: brightness,
); );
// set high contrast theme
if (highContrast) {
theme = theme
.copyWith(
surface: brightness == Brightness.light ? Colors.white : Colors.black,
)
.harmonized();
}
return theme;
// TODO isolate is not working // TODO isolate is not working
// see https://github.com/flutter/flutter/issues/119207 // see https://github.com/flutter/flutter/issues/119207
// use isolate to generate the color scheme // use isolate to generate the color scheme
@ -50,14 +61,18 @@ FutureOr<ColorScheme?> themeOfLibraryItem(
ThemeOfLibraryItemRef ref, ThemeOfLibraryItemRef ref,
String? itemId, { String? itemId, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) async { }) async {
if (itemId == null) { if (itemId == null) {
return null; return null;
} }
final coverImage = await ref.watch(coverImageProvider(itemId).future); final coverImage = await ref.watch(coverImageProvider(itemId).future);
final val = await ref.watch( final val = await ref.watch(
themeFromCoverProvider(MemoryImage(coverImage), brightness: brightness) themeFromCoverProvider(
.future, MemoryImage(coverImage),
brightness: brightness,
highContrast: highContrast,
).future,
); );
return val; return val;
// coverImage.when( // coverImage.when(

View file

@ -6,7 +6,7 @@ part of 'theme_from_cover_provider.dart';
// RiverpodGenerator // RiverpodGenerator
// ************************************************************************** // **************************************************************************
String _$themeFromCoverHash() => r'a549513a0dcdff76be94488baf38a8b886ce63eb'; String _$themeFromCoverHash() => r'f656614e2d4851acdfa16d249b3198ae0e1d6d6f';
/// Copied from Dart SDK /// Copied from Dart SDK
class _SystemHash { class _SystemHash {
@ -42,10 +42,12 @@ class ThemeFromCoverFamily extends Family<AsyncValue<FutureOr<ColorScheme?>>> {
ThemeFromCoverProvider call( ThemeFromCoverProvider call(
ImageProvider<Object> img, { ImageProvider<Object> img, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) { }) {
return ThemeFromCoverProvider( return ThemeFromCoverProvider(
img, img,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
); );
} }
@ -56,6 +58,7 @@ class ThemeFromCoverFamily extends Family<AsyncValue<FutureOr<ColorScheme?>>> {
return call( return call(
provider.img, provider.img,
brightness: provider.brightness, brightness: provider.brightness,
highContrast: provider.highContrast,
); );
} }
@ -80,11 +83,13 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
ThemeFromCoverProvider( ThemeFromCoverProvider(
ImageProvider<Object> img, { ImageProvider<Object> img, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) : this._internal( }) : this._internal(
(ref) => themeFromCover( (ref) => themeFromCover(
ref as ThemeFromCoverRef, ref as ThemeFromCoverRef,
img, img,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
), ),
from: themeFromCoverProvider, from: themeFromCoverProvider,
name: r'themeFromCoverProvider', name: r'themeFromCoverProvider',
@ -97,6 +102,7 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
ThemeFromCoverFamily._allTransitiveDependencies, ThemeFromCoverFamily._allTransitiveDependencies,
img: img, img: img,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
); );
ThemeFromCoverProvider._internal( ThemeFromCoverProvider._internal(
@ -108,10 +114,12 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
required super.from, required super.from,
required this.img, required this.img,
required this.brightness, required this.brightness,
required this.highContrast,
}) : super.internal(); }) : super.internal();
final ImageProvider<Object> img; final ImageProvider<Object> img;
final Brightness brightness; final Brightness brightness;
final bool highContrast;
@override @override
Override overrideWith( Override overrideWith(
@ -129,6 +137,7 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
debugGetCreateSourceHash: null, debugGetCreateSourceHash: null,
img: img, img: img,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
), ),
); );
} }
@ -142,7 +151,8 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
bool operator ==(Object other) { bool operator ==(Object other) {
return other is ThemeFromCoverProvider && return other is ThemeFromCoverProvider &&
other.img == img && other.img == img &&
other.brightness == brightness; other.brightness == brightness &&
other.highContrast == highContrast;
} }
@override @override
@ -150,6 +160,7 @@ class ThemeFromCoverProvider extends FutureProvider<FutureOr<ColorScheme?>> {
var hash = _SystemHash.combine(0, runtimeType.hashCode); var hash = _SystemHash.combine(0, runtimeType.hashCode);
hash = _SystemHash.combine(hash, img.hashCode); hash = _SystemHash.combine(hash, img.hashCode);
hash = _SystemHash.combine(hash, brightness.hashCode); hash = _SystemHash.combine(hash, brightness.hashCode);
hash = _SystemHash.combine(hash, highContrast.hashCode);
return _SystemHash.finish(hash); return _SystemHash.finish(hash);
} }
@ -161,6 +172,9 @@ mixin ThemeFromCoverRef on FutureProviderRef<FutureOr<ColorScheme?>> {
/// The parameter `brightness` of this provider. /// The parameter `brightness` of this provider.
Brightness get brightness; Brightness get brightness;
/// The parameter `highContrast` of this provider.
bool get highContrast;
} }
class _ThemeFromCoverProviderElement class _ThemeFromCoverProviderElement
@ -172,10 +186,12 @@ class _ThemeFromCoverProviderElement
ImageProvider<Object> get img => (origin as ThemeFromCoverProvider).img; ImageProvider<Object> get img => (origin as ThemeFromCoverProvider).img;
@override @override
Brightness get brightness => (origin as ThemeFromCoverProvider).brightness; Brightness get brightness => (origin as ThemeFromCoverProvider).brightness;
@override
bool get highContrast => (origin as ThemeFromCoverProvider).highContrast;
} }
String _$themeOfLibraryItemHash() => String _$themeOfLibraryItemHash() =>
r'a1d0e5d81f4debe88d5a6ce46c3af28623ad4273'; r'b2677daf31a6a53f3f237e5204c62dff5ec43171';
/// See also [themeOfLibraryItem]. /// See also [themeOfLibraryItem].
@ProviderFor(themeOfLibraryItem) @ProviderFor(themeOfLibraryItem)
@ -190,10 +206,12 @@ class ThemeOfLibraryItemFamily extends Family<AsyncValue<ColorScheme?>> {
ThemeOfLibraryItemProvider call( ThemeOfLibraryItemProvider call(
String? itemId, { String? itemId, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) { }) {
return ThemeOfLibraryItemProvider( return ThemeOfLibraryItemProvider(
itemId, itemId,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
); );
} }
@ -204,6 +222,7 @@ class ThemeOfLibraryItemFamily extends Family<AsyncValue<ColorScheme?>> {
return call( return call(
provider.itemId, provider.itemId,
brightness: provider.brightness, brightness: provider.brightness,
highContrast: provider.highContrast,
); );
} }
@ -228,11 +247,13 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
ThemeOfLibraryItemProvider( ThemeOfLibraryItemProvider(
String? itemId, { String? itemId, {
Brightness brightness = Brightness.dark, Brightness brightness = Brightness.dark,
bool highContrast = false,
}) : this._internal( }) : this._internal(
(ref) => themeOfLibraryItem( (ref) => themeOfLibraryItem(
ref as ThemeOfLibraryItemRef, ref as ThemeOfLibraryItemRef,
itemId, itemId,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
), ),
from: themeOfLibraryItemProvider, from: themeOfLibraryItemProvider,
name: r'themeOfLibraryItemProvider', name: r'themeOfLibraryItemProvider',
@ -245,6 +266,7 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
ThemeOfLibraryItemFamily._allTransitiveDependencies, ThemeOfLibraryItemFamily._allTransitiveDependencies,
itemId: itemId, itemId: itemId,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
); );
ThemeOfLibraryItemProvider._internal( ThemeOfLibraryItemProvider._internal(
@ -256,10 +278,12 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
required super.from, required super.from,
required this.itemId, required this.itemId,
required this.brightness, required this.brightness,
required this.highContrast,
}) : super.internal(); }) : super.internal();
final String? itemId; final String? itemId;
final Brightness brightness; final Brightness brightness;
final bool highContrast;
@override @override
Override overrideWith( Override overrideWith(
@ -276,6 +300,7 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
debugGetCreateSourceHash: null, debugGetCreateSourceHash: null,
itemId: itemId, itemId: itemId,
brightness: brightness, brightness: brightness,
highContrast: highContrast,
), ),
); );
} }
@ -289,7 +314,8 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
bool operator ==(Object other) { bool operator ==(Object other) {
return other is ThemeOfLibraryItemProvider && return other is ThemeOfLibraryItemProvider &&
other.itemId == itemId && other.itemId == itemId &&
other.brightness == brightness; other.brightness == brightness &&
other.highContrast == highContrast;
} }
@override @override
@ -297,6 +323,7 @@ class ThemeOfLibraryItemProvider extends FutureProvider<ColorScheme?> {
var hash = _SystemHash.combine(0, runtimeType.hashCode); var hash = _SystemHash.combine(0, runtimeType.hashCode);
hash = _SystemHash.combine(hash, itemId.hashCode); hash = _SystemHash.combine(hash, itemId.hashCode);
hash = _SystemHash.combine(hash, brightness.hashCode); hash = _SystemHash.combine(hash, brightness.hashCode);
hash = _SystemHash.combine(hash, highContrast.hashCode);
return _SystemHash.finish(hash); return _SystemHash.finish(hash);
} }
@ -308,6 +335,9 @@ mixin ThemeOfLibraryItemRef on FutureProviderRef<ColorScheme?> {
/// The parameter `brightness` of this provider. /// The parameter `brightness` of this provider.
Brightness get brightness; Brightness get brightness;
/// The parameter `highContrast` of this provider.
bool get highContrast;
} }
class _ThemeOfLibraryItemProviderElement class _ThemeOfLibraryItemProviderElement
@ -319,6 +349,8 @@ class _ThemeOfLibraryItemProviderElement
@override @override
Brightness get brightness => Brightness get brightness =>
(origin as ThemeOfLibraryItemProvider).brightness; (origin as ThemeOfLibraryItemProvider).brightness;
@override
bool get highContrast => (origin as ThemeOfLibraryItemProvider).highContrast;
} }
// ignore_for_file: type=lint // ignore_for_file: type=lint
// ignore_for_file: subtype_of_sealed_class, invalid_use_of_internal_member, invalid_use_of_visible_for_testing_member // ignore_for_file: subtype_of_sealed_class, invalid_use_of_internal_member, invalid_use_of_visible_for_testing_member