From 758e4cdc8337d9f19fe93fff6779db9cae856197 Mon Sep 17 00:00:00 2001 From: Dr-Blank <64108942+Dr-Blank@users.noreply.github.com> Date: Sat, 5 Oct 2024 04:48:52 -0400 Subject: [PATCH] refactor: update personalized view handling, improve GitHub issue link, and adjust VaaniLogo size --- lib/api/api_provider.dart | 2 ++ lib/api/api_provider.g.dart | 2 +- lib/features/onboarding/view/user_login_with_password.dart | 7 +++++-- lib/features/you/view/you_page.dart | 5 +++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/lib/api/api_provider.dart b/lib/api/api_provider.dart index bc50f8a..fb0a938 100644 --- a/lib/api/api_provider.dart +++ b/lib/api/api_provider.dart @@ -116,6 +116,8 @@ class PersonalizedView extends _$PersonalizedView { ref.read(apiSettingsProvider.notifier).updateState( apiSettings.copyWith(activeLibraryId: login.userDefaultLibraryId), ); + yield []; + return; } // try to find in cache // final cacheKey = 'personalizedView:${apiSettings.activeLibraryId}'; diff --git a/lib/api/api_provider.g.dart b/lib/api/api_provider.g.dart index 796adf7..ec2eeab 100644 --- a/lib/api/api_provider.g.dart +++ b/lib/api/api_provider.g.dart @@ -648,7 +648,7 @@ class _LoginProviderElement AuthenticatedUser? get user => (origin as LoginProvider).user; } -String _$personalizedViewHash() => r'65c0bc60e312d290498ab488496495114d407ccb'; +String _$personalizedViewHash() => r'425e89d99d7e4712b4d6a688f3a12442bd66584f'; /// fetch the personalized view /// diff --git a/lib/features/onboarding/view/user_login_with_password.dart b/lib/features/onboarding/view/user_login_with_password.dart index 43a52e5..7628959 100644 --- a/lib/features/onboarding/view/user_login_with_password.dart +++ b/lib/features/onboarding/view/user_login_with_password.dart @@ -9,6 +9,7 @@ import 'package:vaani/api/authenticated_user_provider.dart'; import 'package:vaani/hacks/fix_autofill_losing_focus.dart'; import 'package:vaani/models/error_response.dart'; import 'package:vaani/router/router.dart'; +import 'package:vaani/settings/constants.dart'; import 'package:vaani/settings/models/models.dart' as model; import 'package:vaani/shared/utils.dart'; @@ -206,8 +207,10 @@ Future handleServerError( onPressed: () { // open an issue on the github page handleLaunchUrl( - Uri.parse( - 'https://github.com/Dr-Blank/Vaani/issues', + AppMetadata.githubRepo + // append the issue url + .replace( + path: '${AppMetadata.githubRepo.path}/issues/new', ), ); }, diff --git a/lib/features/you/view/you_page.dart b/lib/features/you/view/you_page.dart index 2a7bee2..11fa89d 100644 --- a/lib/features/you/view/you_page.dart +++ b/lib/features/you/view/you_page.dart @@ -105,7 +105,6 @@ class YouPage extends HookConsumerWidget { showNotImplementedToast(context); }, ), - AboutListTile( icon: const Icon(Icons.info), applicationName: AppMetadata.appName, @@ -128,7 +127,9 @@ class YouPage extends HookConsumerWidget { Theme.of(context).colorScheme.primary, BlendMode.srcIn, ), - child: const VaaniLogo(), + child: const VaaniLogo( + size: 48, + ), ), ), ],