From 3b3162aec144e183dc7bdfded96017a7304a3bba Mon Sep 17 00:00:00 2001
From: mikiher <mikiher@gmail.com>
Date: Fri, 18 Oct 2024 09:19:06 +0300
Subject: [PATCH] Add REINDEX NOCASE migration and update v2.15.0 migration

---
 server/migrations/changelog.md                |  7 +--
 .../v2.15.0-series-column-unique.js           |  4 ++
 server/migrations/v2.15.1-reindex-nocase.js   | 43 +++++++++++++++++++
 3 files changed, 51 insertions(+), 3 deletions(-)
 create mode 100644 server/migrations/v2.15.1-reindex-nocase.js

diff --git a/server/migrations/changelog.md b/server/migrations/changelog.md
index b5dde7492..92be2cd5b 100644
--- a/server/migrations/changelog.md
+++ b/server/migrations/changelog.md
@@ -2,6 +2,7 @@
 
 Please add a record of every database migration that you create to this file. This will help us keep track of changes to the database schema over time.
 
-| Server Version | Migration Script Name        | Description                                       |
-| -------------- | ---------------------------- | ------------------------------------------------- |
-| v2.15.0        | v2.15.0-series-column-unique | Series must have unique names in the same library |
+| Server Version | Migration Script Name        | Description                                                                          |
+| -------------- | ---------------------------- | ------------------------------------------------------------------------------------ |
+| v2.15.0        | v2.15.0-series-column-unique | Series must have unique names in the same library                                    |
+| v2.15.1        | v2.15.1-reindex-nocase       | Fix potential db corruption issues due to bad sqlite extension introduced in v2.12.0 |
diff --git a/server/migrations/v2.15.0-series-column-unique.js b/server/migrations/v2.15.0-series-column-unique.js
index 96b0ea604..538279785 100644
--- a/server/migrations/v2.15.0-series-column-unique.js
+++ b/server/migrations/v2.15.0-series-column-unique.js
@@ -18,6 +18,10 @@ async function up({ context: { queryInterface, logger } }) {
   // Upwards migration script
   logger.info('[2.15.0 migration] UPGRADE BEGIN: 2.15.0-series-column-unique ')
 
+  // Run reindex nocase to fix potential corruption issues due to the bad sqlite extension introduced in v2.12.0
+  logger.info('[2.15.0 migration] Reindexing NOCASE indices to potential fix hidden corruption issues')
+  await queryInterface.sequelize.query('REINDEX NOCASE;')
+
   // Check if the unique index already exists
   const seriesIndexes = await queryInterface.showIndex('Series')
   if (seriesIndexes.some((index) => index.name === 'unique_series_name_per_library')) {
diff --git a/server/migrations/v2.15.1-reindex-nocase.js b/server/migrations/v2.15.1-reindex-nocase.js
new file mode 100644
index 000000000..2ec9487d2
--- /dev/null
+++ b/server/migrations/v2.15.1-reindex-nocase.js
@@ -0,0 +1,43 @@
+/**
+ * @typedef MigrationContext
+ * @property {import('sequelize').QueryInterface} queryInterface - a suquelize QueryInterface object.
+ * @property {import('../Logger')} logger - a Logger object.
+ *
+ * @typedef MigrationOptions
+ * @property {MigrationContext} context - an object containing the migration context.
+ */
+
+/**
+ * This upward migration script fixes old database corruptions due to the a bad sqlite extension introduced in v2.12.0.
+ *
+ * @param {MigrationOptions} options - an object containing the migration context.
+ * @returns {Promise<void>} - A promise that resolves when the migration is complete.
+ */
+async function up({ context: { queryInterface, logger } }) {
+  // Upwards migration script
+  logger.info('[2.15.1 migration] UPGRADE BEGIN: 2.15.1-reindex-nocase ')
+
+  // Run reindex nocase to fix potential corruption issues due to the bad sqlite extension introduced in v2.12.0
+  logger.info('[2.15.1 migration] Reindexing NOCASE indices to fix potential hidden corruption issues')
+  await queryInterface.sequelize.query('REINDEX NOCASE;')
+
+  logger.info('[2.15.1 migration] UPGRADE END: 2.15.1-reindex-nocase ')
+}
+
+/**
+ * This downward migration script is a no-op.
+ *
+ * @param {MigrationOptions} options - an object containing the migration context.
+ * @returns {Promise<void>} - A promise that resolves when the migration is complete.
+ */
+async function down({ context: { queryInterface, logger } }) {
+  // Downward migration script
+  logger.info('[2.15.1 migration] DOWNGRADE BEGIN: 2.15.1-reindex-nocase ')
+
+  // This migration is a no-op
+  logger.info('[2.15.1 migration] No action required for downgrade')
+
+  logger.info('[2.15.1 migration] DOWNGRADE END: 2.15.1-reindex-nocase ')
+}
+
+module.exports = { up, down }