groove/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-12 06:21:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix podcast episode sort for pre-1970 broadcast dates

Browse source 
Same root cause as #3620: String(value).localeCompare(..., {numeric:true})
treats the "-" of negative ms epochs as a non-numeric character, so
pre-1970 broadcast dates sort lexically. Switch the primary publishedAt
branch and the same-named tiebreaker to numeric subtraction. Other sort
keys remain on localeCompare for natural-sort behaviour.

Verified with a paste-into-console reproducer; see PR description.

Developed with the help of Claude (Anthropic), reviewed and verified by me.
This commit is contained in:
Julien Cornebise 2026-05-10 17:33:21 +01:00
parent 47ea6b5092
commit 537d3fe17d
No known key found for this signature in database
GPG key ID: 7A8D8633AD57FAFE
1 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
client/components/tables/podcast/LazyEpisodesTable.vue
View file

@ -194,14 +194,18 @@ export default {
bValue = b[this.sortKey]
}
// Sort episodes with no pub date as the oldest
// publishedAt is a numeric ms epoch (negative for pre-1970 broadcasts).
// Compare numerically so the leading "-" of negative epochs doesn't
// break Intl.Collator{numeric:true}, which only handles unsigned digit
// runs. Missing dates count as oldest.
if (this.sortKey === 'publishedAt') {
if (!aValue) aValue = Number.MAX_VALUE
if (!bValue) bValue = Number.MAX_VALUE
const av = aValue == null ? Number.NEGATIVE_INFINITY : Number(aValue)
const bv = bValue == null ? Number.NEGATIVE_INFINITY : Number(bValue)
return av < bv ? -1 : av > bv ? 1 : 0
}
const primaryCompare = String(aValue).localeCompare(String(bValue), undefined, { numeric: true, sensitivity: 'base' })
if (primaryCompare !== 0 || this.sortKey === 'publishedAt') return primaryCompare
if (primaryCompare !== 0) return primaryCompare
// When sorting by season, secondary sort is by episode number
if (this.sortKey === 'season') {
@ -212,11 +216,10 @@ export default {
if (secondaryCompare !== 0) return secondaryCompare
}
// Final sort by publishedAt
let aPubDate = a.publishedAt || Number.MAX_VALUE
let bPubDate = b.publishedAt || Number.MAX_VALUE
return String(aPubDate).localeCompare(String(bPubDate), undefined, { numeric: true, sensitivity: 'base' })
// Final tiebreaker: numeric publishedAt
const apa = a.publishedAt == null ? Number.NEGATIVE_INFINITY : Number(a.publishedAt)
const bpa = b.publishedAt == null ? Number.NEGATIVE_INFINITY : Number(b.publishedAt)
return apa < bpa ? -1 : apa > bpa ? 1 : 0
})
},
episodesList() {