groove/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-13 06:51:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Redesign Smart Speed to dynamically adjust playbackRate instead of dropping samples, fix TimeMapper bugs by mapping audioContext to media time, and prevent SilenceMap memory leak by capping regions

Browse source
This commit is contained in:
Jonathan Baldie 2026-05-01 21:47:34 +01:00
parent fa2460868e
commit 545c77a2dc
4 changed files with 32 additions and 314 deletions
Download patch file Download diff file Expand all files Collapse all files

159
test/client/players/smart-speed/SilenceCompressor.test.js
View file

@ -1,159 +0,0 @@
const chai = require('chai')
const expect = chai.expect
// Mock AudioWorklet environment
class MockMessagePort {
constructor() {
this.messages = []
}
postMessage(msg) {
this.messages.push(msg)
}
}
class AudioWorkletProcessor {
constructor() {
this.port = new MockMessagePort()
}
}
global.AudioWorkletProcessor = AudioWorkletProcessor
global.registerProcessor = (name, constructor) => {
global.RegisteredProcessor = constructor
}
global.currentTime = 0
// Require the processor file which will call registerProcessor
require('../../../../client/players/smart-speed/SilenceCompressorProcessor')
const SilenceCompressorProcessor = global.RegisteredProcessor
describe('SilenceCompressorProcessor', () => {
let processor
beforeEach(() => {
global.currentTime = 0
processor = new SilenceCompressorProcessor()
})
function createProcessInputs(numFrames) {
const input = [new Float32Array(numFrames)]
for (let i = 0; i < numFrames; i++) {
input[0][i] = 1.0 // fill with 1.0 to easily check what passes through
}
return [[input[0]]]
}
function createProcessOutputs(numFrames) {
return [[new Float32Array(numFrames)]]
}
describe('Must Pass (GREEN)', () => {
it('1. With no regions, all samples pass through unchanged', () => {
const inputs = createProcessInputs(128)
const outputs = createProcessOutputs(128)
processor.process(inputs, outputs, {})
for (let i = 0; i < 128; i++) {
expect(outputs[0][0][i]).to.equal(1.0)
}
})
it('2. With region, samples within region are dropped at correct ratio', () => {
processor.port.onmessage({ data: { type: 'set-ratio', value: 2.0 } })
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 0, end: 1000 }] } })
const inputs = createProcessInputs(128)
// Make input values equal to their index so we can verify interpolation/skipping
for (let i = 0; i < 128; i++) inputs[0][0][i] = i
const outputs = createProcessOutputs(128)
// Inside region, ratio 2.0 means we skip every other sample
processor.process(inputs, outputs, {})
// The first few samples will be subject to the crossfade ramp!
// To strictly test dropping at correct ratio, let's look at samples after the 5ms ramp.
// 5ms at 48000Hz (sample rate is usually 44100 or 48000, let's use 48000 for calculation if available,
// wait, currentTime is in seconds, standard Web Audio API).
// Let's just simulate process and verify port messages for time saved.
// But requirement 2 says "samples within region are dropped at correct ratio".
// Let's assert that the read index advances faster than write index.
// With ratio 2.0, the last sample written shouldn't be the last sample of input.
expect(outputs[0][0][127]).to.not.equal(127) // It should be something like 127*2 if we could fit it
})
it('3. Crossfade ramp at region entry (first 5ms gain 0→1)', () => {
// Test 5ms ramp. Sample rate is available via global.sampleRate in Web Audio API. Let's mock it.
global.sampleRate = 48000
processor.port.onmessage({ data: { type: 'set-ratio', value: 2.0 } })
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 0, end: 1000 }] } })
const inputs = createProcessInputs(128)
const outputs = createProcessOutputs(128)
processor.process(inputs, outputs, {})
// Entry ramp: gain goes from 0 to 1 over 5ms (240 samples at 48kHz)
// At index 0, gain should be 0.
expect(outputs[0][0][0]).to.equal(0)
// Gain should be increasing
expect(outputs[0][0][10]).to.be.greaterThan(0)
expect(outputs[0][0][10]).to.be.lessThan(1)
})
it('4. Crossfade ramp at region exit (last 5ms gain 1→0)', () => {
global.sampleRate = 48000
processor.port.onmessage({ data: { type: 'set-ratio', value: 2.0 } })
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 0, end: 200 }] } }) // 10ms region
// advance time to 9ms, inside the 5ms exit ramp
global.currentTime = 0.199
const inputs = createProcessInputs(128)
const outputs = createProcessOutputs(128)
processor.process(inputs, outputs, {})
// Exit ramp is active, gain should be going down
// Not precisely testing the values, just that it's less than 1 and greater than 0
expect(outputs[0][0][0]).to.be.lessThan(1)
})
it('5. Regions shorter than 200ms pass through unchanged', () => {
processor.port.onmessage({ data: { type: 'set-ratio', value: 2.0 } })
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 0, end: 199 }] } })
const inputs = createProcessInputs(128)
const outputs = createProcessOutputs(128)
processor.process(inputs, outputs, {})
for (let i = 0; i < 128; i++) {
expect(outputs[0][0][i]).to.equal(1.0)
}
})
it('6. ratio=1.0 passes all audio through unchanged', () => {
processor.port.onmessage({ data: { type: 'set-ratio', value: 1.0 } })
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 0, end: 1000 }] } })
const inputs = createProcessInputs(128)
const outputs = createProcessOutputs(128)
processor.process(inputs, outputs, {})
for (let i = 0; i < 128; i++) {
expect(outputs[0][0][i]).to.equal(1.0)
}
})
it('7. set-regions message updates internal regions', () => {
processor.port.onmessage({ data: { type: 'set-regions', regions: [{ start: 100, end: 500 }] } })
expect(processor.regions.length).to.equal(1)
expect(processor.regions[0].start).to.equal(100)
})
it('8. set-ratio message updates internal ratio', () => {
processor.port.onmessage({ data: { type: 'set-ratio', value: 2.5 } })
expect(processor.ratio).to.equal(2.5)
})
})
})