Update podcast controller to load library items from db

server/controllers/LibraryItemController.js

@@ -309,18 +309,22 @@ class LibraryItemController {
     const hardDelete = req.query.hard == 1 // Delete files from filesystem
 
     const { libraryItemIds } = req.body
-    if (!libraryItemIds || !libraryItemIds.length) {
-      return res.sendStatus(500)
+    if (!libraryItemIds?.length) {
+      return res.status(400).send('Invalid request body')
     }
 
-    const itemsToDelete = Database.libraryItems.filter(li => libraryItemIds.includes(li.id))
+    const itemsToDelete = await Database.models.libraryItem.getAllOldLibraryItems({
+      id: libraryItemIds
+    })
+
     if (!itemsToDelete.length) {
       return res.sendStatus(404)
     }
-    for (let i = 0; i < itemsToDelete.length; i++) {
-      const libraryItemPath = itemsToDelete[i].path
-      Logger.info(`[LibraryItemController] Deleting Library Item "${itemsToDelete[i].media.metadata.title}"`)
-      await this.handleDeleteLibraryItem(itemsToDelete[i])
+
+    for (const libraryItem of itemsToDelete) {
+      const libraryItemPath = libraryItem.path
+      Logger.info(`[LibraryItemController] Deleting Library Item "${libraryItem.media.metadata.title}"`)
+      await this.handleDeleteLibraryItem(libraryItem)
       if (hardDelete) {
         Logger.info(`[LibraryItemController] Deleting library item from file system at "${libraryItemPath}"`)
         await fs.remove(libraryItemPath).catch((error) => {
@@ -333,22 +337,21 @@ class LibraryItemController {
 
   // POST: api/items/batch/update
   async batchUpdate(req, res) {
-    var updatePayloads = req.body
-    if (!updatePayloads || !updatePayloads.length) {
+    const updatePayloads = req.body
+    if (!updatePayloads?.length) {
       return res.sendStatus(500)
     }
 
-    var itemsUpdated = 0
+    let itemsUpdated = 0
 
-    for (let i = 0; i < updatePayloads.length; i++) {
-      var mediaPayload = updatePayloads[i].mediaPayload
-      var libraryItem = Database.libraryItems.find(_li => _li.id === updatePayloads[i].id)
+    for (const updatePayload of updatePayloads) {
+      const mediaPayload = updatePayload.mediaPayload
+      const libraryItem = await Database.models.libraryItem.getOldById(updatePayload.id)
       if (!libraryItem) return null
 
       await this.createAuthorsAndSeriesForItemUpdate(mediaPayload, libraryItem.libraryId)
 
-      var hasUpdates = libraryItem.media.update(mediaPayload)
-      if (hasUpdates) {
+      if (libraryItem.media.update(mediaPayload)) {
         Logger.debug(`[LibraryItemController] Updated library item media ${libraryItem.media.metadata.title}`)
         await Database.updateLibraryItem(libraryItem)
         SocketAuthority.emitter('item_updated', libraryItem.toJSONExpanded())
@@ -368,13 +371,11 @@ class LibraryItemController {
     if (!libraryItemIds.length) {
       return res.status(403).send('Invalid payload')
     }
-    const libraryItems = []
-    libraryItemIds.forEach((lid) => {
-      const li = Database.libraryItems.find(_li => _li.id === lid)
-      if (li) libraryItems.push(li.toJSONExpanded())
+    const libraryItems = await Database.models.libraryItem.getAllOldLibraryItems({
+      id: libraryItemIds
     })
     res.json({
-      libraryItems
+      libraryItems: libraryItems.map(li => li.toJSONExpanded())
     })
   }
 

server/controllers/PlaylistController.js

@@ -133,7 +133,7 @@ class PlaylistController {
     const itemsToAdd = req.body.items
     let hasUpdated = false
 
-    let order = playlist.items.length
+    let order = playlist.items.length + 1
     const playlistMediaItems = []
     for (const item of itemsToAdd) {
       if (!item.libraryItemId) {

server/controllers/PodcastController.js

@@ -34,9 +34,13 @@ class PodcastController {
     const podcastPath = filePathToPOSIX(payload.path)
 
     // Check if a library item with this podcast folder exists already
-    const existingLibraryItem = Database.libraryItems.find(li => li.path === podcastPath && li.libraryId === library.id)
+    const existingLibraryItem = (await Database.models.libraryItem.count({
+      where: {
+        path: podcastPath
+      }
+    })) > 0
     if (existingLibraryItem) {
-      Logger.error(`[PodcastController] Podcast already exists with name "${existingLibraryItem.media.metadata.title}" at path "${podcastPath}"`)
+      Logger.error(`[PodcastController] Podcast already exists at path "${podcastPath}"`)
       return res.status(400).send('Podcast already exists')
     }
 
@@ -268,18 +272,27 @@ class PodcastController {
     }
 
     // Update/remove playlists that had this podcast episode
-    const playlistsWithEpisode = await Database.models.playlist.getPlaylistsForMediaItemIds([episodeId])
-    for (const playlist of playlistsWithEpisode) {
-      playlist.removeItem(libraryItem.id, episodeId)
+    const playlistMediaItems = await Database.models.playlistMediaItem.findAll({
+      where: {
+        mediaItemId: episodeId
+      },
+      include: {
+        model: Database.models.playlist,
+        include: Database.models.playlistMediaItem
+      }
+    })
+    for (const pmi of playlistMediaItems) {
+      const numItems = pmi.playlist.playlistMediaItems.length - 1
 
-      // If playlist is now empty then remove it
-      if (!playlist.items.length) {
+      if (!numItems) {
         Logger.info(`[PodcastController] Playlist "${playlist.name}" has no more items - removing it`)
-        await Database.removePlaylist(playlist.id)
-        SocketAuthority.clientEmitter(playlist.userId, 'playlist_removed', playlist.toJSONExpanded(Database.libraryItems))
+        const jsonExpanded = await pmi.playlist.getOldJsonExpanded()
+        SocketAuthority.clientEmitter(pmi.playlist.userId, 'playlist_removed', jsonExpanded)
+        await pmi.playlist.destroy()
       } else {
-        await Database.updatePlaylist(playlist)
-        SocketAuthority.clientEmitter(playlist.userId, 'playlist_updated', playlist.toJSONExpanded(Database.libraryItems))
+        await pmi.destroy()
+        const jsonExpanded = await pmi.playlist.getOldJsonExpanded()
+        SocketAuthority.clientEmitter(pmi.playlist.userId, 'playlist_updated', jsonExpanded)
       }
     }
 
@@ -298,9 +311,9 @@ class PodcastController {
     res.json(libraryItem.toJSON())
   }
 
-  middleware(req, res, next) {
-    const item = Database.libraryItems.find(li => li.id === req.params.id)
-    if (!item || !item.media) return res.sendStatus(404)
+  async middleware(req, res, next) {
+    const item = await Database.models.libraryItem.getOldById(req.params.id)
+    if (!item?.media) return res.sendStatus(404)
 
     if (!item.isPodcast) {
       return res.sendStatus(500)