From a8081b9a74451882d4250a188cd038801f14fa25 Mon Sep 17 00:00:00 2001
From: Harrison Rose <sevenlayercookie@gmail.com>
Date: Mon, 22 Jul 2024 22:45:40 -0500
Subject: [PATCH] or would it be better to return just the slug instead of the
 whole share object?

---
 server/controllers/ShareController.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/server/controllers/ShareController.js b/server/controllers/ShareController.js
index e28cd2011..36171df49 100644
--- a/server/controllers/ShareController.js
+++ b/server/controllers/ShareController.js
@@ -238,18 +238,15 @@ class ShareController {
     res.sendStatus(204)
   }
   /**
-   * Public route - requires share_session_id cookie
+   * Public route
    * GET: /api/share/mediaitem/:id
    * get existing share from mediaItemId
+   *  (or would it be better to return just the slug?)
    * 
    * @param {import('express').Request} req
    * @param {import('express').Response} res
    */
   async getMediaItemShare(req, res) {
-    if (!req.cookies.share_session_id) {
-      return res.status(404).send('Share session not set')
-    }
-    
     const mediaItemId = req.params.id;
     
     if (!mediaItemId || typeof mediaItemId !== 'string') {
@@ -263,7 +260,7 @@ class ShareController {
       });
 
       if (existingMediaItemShare) {
-        return res.status(200).json(existingMediaItemShare.toJSONForClient());
+        return res.status(200).json(existingMediaItemShare.toJSONForClient()); // or would it be better to return just the slug?
       } else {
         return res.status(404).send('Share not found');
       }