groove/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-07-07 09:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

MR: Address reviewer feedback: remove dotfiles option, fix keepAliveTimeout comment

Browse source
This commit is contained in:
Trevor Renshaw 2026-05-17 09:41:20 -06:00
parent 09a84837cf
commit b2ba94eced
3 changed files with 10 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
test/server/controllers/LibraryItemController.test.js
View file

@ -332,26 +332,19 @@ describe('LibraryItemController', () => {
})
it('should call res.sendFile for single-file library items', async () => {
res.sendFile.callsFake((filePath, opts, cb) => cb(null))
res.sendFile.callsFake((filePath, cb) => cb(null))
await LibraryItemController.download(req, res)
expect(res.sendFile.calledOnce).to.be.true
})
it('should pass { dotfiles: "allow" } option to res.sendFile', async () => {
res.sendFile.callsFake((filePath, opts, cb) => cb(null))
await LibraryItemController.download(req, res)
const opts = res.sendFile.firstCall.args[1]
expect(opts).to.deep.equal({ dotfiles: 'allow' })
})
it('should pass the correct file path to res.sendFile', async () => {
res.sendFile.callsFake((filePath, opts, cb) => cb(null))
res.sendFile.callsFake((filePath, cb) => cb(null))
await LibraryItemController.download(req, res)
expect(res.sendFile.firstCall.args[0]).to.equal('/audiobooks/hitchhikers-guide.mp3')
})
it('should set Content-Disposition attachment header with the filename', async () => {
res.sendFile.callsFake((filePath, opts, cb) => cb(null))
res.sendFile.callsFake((filePath, cb) => cb(null))
await LibraryItemController.download(req, res)
const dispositionCall = res.setHeader.args.find(([header]) => header === 'Content-Disposition')
expect(dispositionCall).to.exist
@ -361,14 +354,14 @@ describe('LibraryItemController', () => {
it('should URL-encode special characters in the Content-Disposition filename', async () => {
req.libraryItem.relPath = 'Book With Spaces & Symbols!.mp3'
res.sendFile.callsFake((filePath, opts, cb) => cb(null))
res.sendFile.callsFake((filePath, cb) => cb(null))
await LibraryItemController.download(req, res)
const dispositionCall = res.setHeader.args.find(([header]) => header === 'Content-Disposition')
expect(dispositionCall[1]).to.include(encodeURIComponent('Book With Spaces & Symbols!.mp3'))
})
it('should return 500 when res.sendFile calls back with an error', async () => {
res.sendFile.callsFake((filePath, opts, cb) => cb(new Error('File not found')))
res.sendFile.callsFake((filePath, cb) => cb(new Error('File not found')))
await LibraryItemController.download(req, res)
expect(res.status.calledWith(500)).to.be.true
expect(res.send.called).to.be.true