groove/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-07-09 02:41:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: harden browse exists predicate coverage

Browse source
This commit is contained in:
Jonathan Finley 2026-03-13 22:15:11 -04:00
parent c164831722
commit cb57d8c372
1 changed files with 54 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

64
test/server/controllers/LibraryController.largeLibraryBrowse.test.js
View file

@ -11,7 +11,20 @@ const libraryItemsBookFilters = require('../../../server/utils/queries/libraryIt
const libraryItemsPodcastFilters = require('../../../server/utils/queries/libraryItemsPodcastFilters') const libraryItemsPodcastFilters = require('../../../server/utils/queries/libraryItemsPodcastFilters')
describe('LibraryController large-library browse contract', () => { describe('LibraryController large-library browse contract', () => {
const getLiteralSql = (predicate) => String(predicate?.attribute?.val || predicate?.attribute || predicate?.left?.val || predicate?.left || '') const buildBookPredicateSql = (where, replacements = {}) => {
const query = Database.sequelize.dialect.queryGenerator.selectQuery(
Database.bookModel.getTableName(),
{
attributes: ['id'],
where: Array.isArray(where) ? where : [where],
replacements,
model: Database.bookModel
},
Database.bookModel
)
return query.replace(/\s+/g, ' ')
}
beforeEach(async () => { beforeEach(async () => {
global.ServerSettings = {} global.ServerSettings = {}
@ -386,22 +399,53 @@ describe('LibraryController large-library browse contract', () => {
}) })
it('builds EXISTS predicates for browse filters and permission-tag checks instead of correlated count subqueries', () => { it('builds EXISTS predicates for browse filters and permission-tag checks instead of correlated count subqueries', () => {
const { mediaWhere: tagWhere } = libraryItemsBookFilters.getMediaGroupQuery('tags', 'Fantasy') const positivePredicates = [
const { mediaWhere: genreWhere } = libraryItemsBookFilters.getMediaGroupQuery('genres', 'Fantasy') libraryItemsBookFilters.getMediaGroupQuery('tags', 'Fantasy'),
const { mediaWhere: narratorWhere } = libraryItemsBookFilters.getMediaGroupQuery('narrators', 'Jane Doe') libraryItemsBookFilters.getMediaGroupQuery('genres', 'Fantasy'),
const { mediaWhere: trackWhere } = libraryItemsBookFilters.getMediaGroupQuery('tracks', 'multi') libraryItemsBookFilters.getMediaGroupQuery('narrators', 'Jane Doe'),
const { mediaWhere: ebookWhere } = libraryItemsBookFilters.getMediaGroupQuery('ebooks', 'ebook') libraryItemsBookFilters.getMediaGroupQuery('tracks', 'multi'),
const permissionWhere = libraryItemsBookFilters.getUserPermissionBookWhereQuery({ libraryItemsBookFilters.getMediaGroupQuery('ebooks', 'ebook')
]
const permissionQuery = libraryItemsBookFilters.getUserPermissionBookWhereQuery({
canAccessExplicitContent: true, canAccessExplicitContent: true,
accessAllTags: false, accessAllTags: false,
itemTagsSelected: ['Fantasy'], itemTagsSelected: ['Fantasy'],
selectedTagsNotAccessible: false selectedTagsNotAccessible: false
}).bookWhere[0] })
;[tagWhere, genreWhere, narratorWhere, trackWhere, ebookWhere, permissionWhere].forEach((predicate) => { positivePredicates.forEach(({ mediaWhere, replacements }) => {
const sql = getLiteralSql(predicate) const sql = buildBookPredicateSql(mediaWhere, replacements)
expect(sql).to.include('EXISTS') expect(sql).to.include('EXISTS')
expect(sql).to.not.include('count(*)') expect(sql).to.not.include('count(*)')
}) })
const permissionSql = buildBookPredicateSql(permissionQuery.bookWhere, permissionQuery.replacements)
expect(permissionSql).to.include('EXISTS')
expect(permissionSql).to.not.include('count(*)')
})
it('builds NOT EXISTS predicates for negative browse filters and inaccessible-tag checks', () => {
const negativePredicates = [
libraryItemsBookFilters.getMediaGroupQuery('tracks', 'none'),
libraryItemsBookFilters.getMediaGroupQuery('ebooks', 'no-ebook'),
libraryItemsBookFilters.getMediaGroupQuery('missing', 'tags'),
libraryItemsBookFilters.getMediaGroupQuery('missing', 'chapters')
]
const permissionQuery = libraryItemsBookFilters.getUserPermissionBookWhereQuery({
canAccessExplicitContent: true,
accessAllTags: false,
itemTagsSelected: ['Fantasy'],
selectedTagsNotAccessible: true
})
negativePredicates.forEach(({ mediaWhere, replacements }) => {
const sql = buildBookPredicateSql(mediaWhere, replacements)
expect(sql).to.include('NOT EXISTS')
expect(sql).to.not.include('count(*)')
})
const permissionSql = buildBookPredicateSql(permissionQuery.bookWhere, permissionQuery.replacements)
expect(permissionSql).to.include('NOT EXISTS')
expect(permissionSql).to.not.include('count(*)')
}) })
}) })