mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-24 12:21:42 +00:00
fix: preserve user-cleared scalar metadata fields on rescan
When absMetadata (metadata.json) is the highest-priority source and a field is null, propagate that null into bookMetadata so lower-priority sources (e.g. audio file tags) cannot overwrite a value the user intentionally cleared. Previously all null values were skipped, causing cleared fields like subtitle to be repopulated from file tags on rescan.
This commit is contained in:
parent
47457ee1e7
commit
dc0899ff61
1 changed files with 12 additions and 2 deletions
|
|
@ -34,8 +34,18 @@ class AbsMetadataFileScanner {
|
||||||
libraryScan.addLog(LogLevel.INFO, `Found metadata file "${metadataFilePath}"`)
|
libraryScan.addLog(LogLevel.INFO, `Found metadata file "${metadataFilePath}"`)
|
||||||
const abMetadata = abmetadataGenerator.parseJson(metadataText) || {}
|
const abMetadata = abmetadataGenerator.parseJson(metadataText) || {}
|
||||||
for (const key in abMetadata) {
|
for (const key in abMetadata) {
|
||||||
// TODO: When to override with null or empty arrays?
|
if (abMetadata[key] === undefined) continue
|
||||||
if (abMetadata[key] === undefined || abMetadata[key] === null) continue
|
if (abMetadata[key] === null) {
|
||||||
|
// Propagate null for scalar string fields so that values intentionally cleared
|
||||||
|
// by the user are preserved when the library is rescanned. absMetadata has the
|
||||||
|
// highest metadata precedence, so a null here means the user explicitly cleared
|
||||||
|
// the field and lower-priority sources (e.g. audio file tags) should not refill it.
|
||||||
|
const clearableStringFields = ['subtitle', 'publishedYear', 'publisher', 'description', 'isbn', 'asin', 'language']
|
||||||
|
if (clearableStringFields.includes(key)) {
|
||||||
|
bookMetadata[key] = null
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
if (key === 'authors' && !abMetadata.authors?.length) continue
|
if (key === 'authors' && !abMetadata.authors?.length) continue
|
||||||
if (key === 'genres' && !abMetadata.genres?.length) continue
|
if (key === 'genres' && !abMetadata.genres?.length) continue
|
||||||
if (key === 'tags' && !abMetadata.tags?.length) continue
|
if (key === 'tags' && !abMetadata.tags?.length) continue
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue