groove/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-08-02 22:51:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Postgres listening stats regression

Browse source 
Before the new minified listening stats path could return 502 because PlaybackSession.afterFind assumed Sequelize model instances even for raw stats rows, and some payloads could serialize invalid totals. After this hotfix the stats helper returns successfully again, with the current dataset benchmarking at about 124ms for full stats and 101ms for minified stats instead of crashing.
This commit is contained in:
Kevin Gatera 2026-03-08 22:30:29 -04:00
parent 377fb71b9c
commit e395c2b668
No known key found for this signature in database
GPG key ID: F0D9F5932458CFB9
2 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
server/models/PlaybackSession.js
View file

@ -273,18 +273,20 @@ class PlaybackSession extends Model {
if (!Array.isArray(findResult)) findResult = [findResult]
for (const instance of findResult) {
const values = instance?.dataValues
if (instance.mediaItemType === 'book' && instance.book !== undefined) {
instance.mediaItem = instance.book
instance.dataValues.mediaItem = instance.dataValues.book
if (values) values.mediaItem = values.book
} else if (instance.mediaItemType === 'podcastEpisode' && instance.podcastEpisode !== undefined) {
instance.mediaItem = instance.podcastEpisode
instance.dataValues.mediaItem = instance.dataValues.podcastEpisode
if (values) values.mediaItem = values.podcastEpisode
}
// To prevent mistakes:
delete instance.book
delete instance.dataValues.book
if (values) delete values.book
delete instance.podcastEpisode
delete instance.dataValues.podcastEpisode
if (values) delete values.podcastEpisode
}
})
}

8
server/routers/ApiRouter.js
View file

@ -583,10 +583,10 @@ class ApiRouter {
if (includeRecentSessions) listeningStats.recentSessions = recentSessions
listeningSessions.forEach((s) => {
const libraryItemId = s.extraData?.libraryItemId || null
let sessionTimeListening = s.timeListening
if (typeof sessionTimeListening == 'string') {
sessionTimeListening = Number(sessionTimeListening)
}
const numericListening = Number(s.timeListening)
const sessionTimeListening = Number.isFinite(numericListening)
? numericListening
: 0
if (s.dayOfWeek) {
if (!listeningStats.dayOfWeek[s.dayOfWeek]) listeningStats.dayOfWeek[s.dayOfWeek] = 0