Compare commits

...

3 commits

Author SHA1 Message Date
advplyr
ec05bd36e4
Merge pull request #4223 from Vito0912/feat/fixCrashEmptyCollection
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Build and Push Docker Image / build (push) Waiting to run
Integration Test / build and test (push) Waiting to run
Run Unit Tests / Run Unit Tests (push) Waiting to run
Fix server crash when a user requests the RSS feed of an empty collection
2025-04-26 13:43:38 -05:00
Vito0912
a1d549a2b1
prettier 2025-04-26 17:46:19 +02:00
Vito0912
812cb5a160
feat/fixCrashEmptyCollection 2025-04-26 17:35:17 +02:00

View file

@ -215,9 +215,13 @@ class FeedEpisode extends Model {
* @returns {Promise<FeedEpisode[]>}
*/
static async createFromBooks(books, feed, slug, transaction) {
const earliestLibraryItemCreatedAt = books.reduce((earliest, book) => {
return book.libraryItem.createdAt < earliest.libraryItem.createdAt ? book : earliest
}).libraryItem.createdAt
// This is never null unless the books array is empty, as this method is not invoked when no books. Reduce needs an initial item
const earliestLibraryItemCreatedAt =
books.length > 0
? books.reduce((earliest, book) => {
return book.libraryItem.createdAt < earliest.libraryItem.createdAt ? book : earliest
}).libraryItem.createdAt
: null
const feedEpisodeObjs = []
let numExisting = 0