From 4fb9a237f88015a05a223f1b6bfd0d6340200d33 Mon Sep 17 00:00:00 2001
From: Pothi Kalimuthu <1254302+pothi@users.noreply.github.com>
Date: Mon, 15 Dec 2025 10:39:16 +0530
Subject: [PATCH] Better naming

---
 ...-ros-v2.rsc => firmware-check-ros-old.rsc} | 21 +++++------------
 scripts/firmware-check-ros.rsc                | 23 +++++++++++++------
 2 files changed, 22 insertions(+), 22 deletions(-)
 rename scripts/{firmware-check-ros-v2.rsc => firmware-check-ros-old.rsc} (57%)

diff --git a/scripts/firmware-check-ros-v2.rsc b/scripts/firmware-check-ros-old.rsc
similarity index 57%
rename from scripts/firmware-check-ros-v2.rsc
rename to scripts/firmware-check-ros-old.rsc
index 9fb617d..6e926ad 100644
--- a/scripts/firmware-check-ros-v2.rsc
+++ b/scripts/firmware-check-ros-old.rsc
@@ -16,27 +16,18 @@
 /system package update
 check-for-updates once
 
-:local updateStatus "incomplete"
 :do {
-  :delay 2s
+  :delay 3s
 
-  :set $updateStatus [get status]
-
-  :if ($updateStatus = "ERROR: no internet connection") do={ :error "ERROT: no internet connection"; }
-  :if ($updateStatus = "ERROR: connection timed out")   do={ :error "ERROR: connection timed out"; }
-
-  :if ($updateStatus = "getting changelog...")          do={ :set $updateStatus "incomplete" }
-  :if ($updateStatus = "finding out latest version...") do={ :set $updateStatus "incomplete" }
-
-  :if ($updateStatus = "New version is available" )     do={ }
-  :if ($updateStatus = "System is already up to date" ) do={ }
-
-} while=( $updateStatus = "incomplete" )
+  :set $versionStatus [get status]
+  # alternative way to get the above info
+  # :set $versionStatus ([print as-value]->"status")
+} while=( $versionStatus = "finding out latest version..." )
 
 :local installedVersion [get installed-version]
 :local latestVersion [get latest-version]
 
-:if ( $updateStatus = "New version is available" ) do={
+:if ( $versionStatus = "New version is available" ) do={
 # alternative method
 # :if ( installedVersion != $latestVersion ) do={
     :log info "A new update is available for Router OS."
diff --git a/scripts/firmware-check-ros.rsc b/scripts/firmware-check-ros.rsc
index 6e926ad..aeb5c3a 100644
--- a/scripts/firmware-check-ros.rsc
+++ b/scripts/firmware-check-ros.rsc
@@ -16,20 +16,29 @@
 /system package update
 check-for-updates once
 
+:local updateStatus "incomplete"
 :do {
-  :delay 3s
+  :delay 2s
 
-  :set $versionStatus [get status]
-  # alternative way to get the above info
-  # :set $versionStatus ([print as-value]->"status")
-} while=( $versionStatus = "finding out latest version..." )
+  :set $updateStatus [get status]
+
+  :if ($updateStatus = "ERROR: no internet connection") do={ :error "ERROT: no internet connection"; }
+  :if ($updateStatus = "ERROR: connection timed out")   do={ :error "ERROR: connection timed out"; }
+
+  :if ($updateStatus = "getting changelog...")          do={ :set $updateStatus "incomplete" }
+  :if ($updateStatus = "finding out latest version...") do={ :set $updateStatus "incomplete" }
+
+  :if ($updateStatus = "New version is available" )     do={ }
+  :if ($updateStatus = "System is already up to date" ) do={ }
+
+} while=( $updateStatus = "incomplete" )
 
 :local installedVersion [get installed-version]
 :local latestVersion [get latest-version]
 
-:if ( $versionStatus = "New version is available" ) do={
 # alternative method
-# :if ( installedVersion != $latestVersion ) do={
+# :if ( $updateStatus = "New version is available" ) do={
+:if ( installedVersion != $latestVersion ) do={
     :log info "A new update is available for Router OS."
     /tool e-mail send to="$adminEmail" \
       subject="Software Update is Available" \