From 87a6e60765e4301aad1b40bf3c84eee6b7ff704a Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Wed, 15 Oct 2025 10:47:56 +0200
Subject: [PATCH] fw-addr-lists: normalize the address in list

---
 fw-addr-lists.rsc | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/fw-addr-lists.rsc b/fw-addr-lists.rsc
index cd136f95..787d2752 100644
--- a/fw-addr-lists.rsc
+++ b/fw-addr-lists.rsc
@@ -21,11 +21,11 @@
   :global CertificateAvailable;
   :global EitherOr;
   :global FetchHuge;
+  :global GetRandom20CharAlNum;
   :global HumanReadableNum;
   :global LogPrint;
   :global LogPrintOnce;
   :global LogPrintVerbose;
-  :global MIN;
   :global ScriptLock;
   :global WaitFullyConnected;
 
@@ -56,6 +56,23 @@
   }
 
   :local ListComment ("managed by " . $ScriptName);
+  :local GenList ($ScriptName . "-" . [ $GetRandom20CharAlNum ]);
+  :local Maskv4 ({});
+  :for I from=0 to=31 do={
+    /ip/firewall/address-list/add dynamic=yes timeout=30s list=$GenList address=("255.255.255.255/" . $I) comment=$I;
+  }
+  :foreach AddressList in=[ /ip/firewall/address-list/find where list=$GenList ] do={
+    :local Address [ /ip/firewall/address-list/get $AddressList ];
+    :set ($Maskv4->($Address->"comment")) [ :toip [ :pick ($Address->"address") 0 [ :find ($Address->"address") "/" ] ] ];
+  }
+  :local Maskv6 ({});
+  :for I from=0 to=128 do={
+    /ipv6/firewall/address-list/add dynamic=yes timeout=30s list=$GenList address=("ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/" . $I) comment=$I;
+  }
+  :foreach AddressList in=[ /ipv6/firewall/address-list/find where list=$GenList ] do={
+    :local Address [ /ipv6/firewall/address-list/get $AddressList ];
+    :set ($Maskv6->($Address->"comment")) [ :toip6 [ :pick ($Address->"address") 0 [ :find ($Address->"address") "/" ] ] ];
+  }
 
   :foreach FwListName,FwList in=$FwAddrLists do={
     :local CntAdd 0;
@@ -114,8 +131,13 @@
         :do {
           :local Branch;
           :if ($Address ~ "^[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}(/[0-9]{1,2})?\$") do={
-            :if ($Address ~ "/32\$") do={
-              :set Address [ :pick $Address 0 ([ :len $Address ] - 3) ];
+            :local Net $Address;
+            :local Cidr 32;
+            :local Slash [ :find $Address "/" ];
+            :if ([ :typeof $Slash ] = "num") do={
+              :set Net [ :toip [ :pick $Address 0 $Slash ] ]
+              :set Cidr [ :pick $Address ($Slash + 1) [ :len $Address ] ];
+              :set Address (([ :toip $Net ] & ($Maskv4->$Cidr)) . "/" . $Cidr);
             }
             :set Branch [ $GetBranch $Address ];
             :set ($IPv4Addresses->$Branch->$Address) $TimeOut;
@@ -123,13 +145,13 @@
           }
           :if ($Address ~ "^[0-9a-zA-Z]*:[0-9a-zA-Z:\\.]+(/[0-9]{1,3})?\$") do={
             :local Net $Address;
-            :local Cidr 64;
+            :local Cidr 128;
             :local Slash [ :find $Address "/" ];
             :if ([ :typeof $Slash ] = "num") do={
               :set Net [ :toip6 [ :pick $Address 0 $Slash ] ]
-              :set Cidr [ $MIN [ :pick $Address ($Slash + 1) [ :len $Address ] ] 64 ];
+              :set Cidr [ :pick $Address ($Slash + 1) [ :len $Address ] ];
             }
-            :set Address (([ :toip6 $Net ] & ffff:ffff:ffff:ffff::) . "/" . $Cidr);
+            :set Address (([ :toip6 $Net ] & ($Maskv6->$Cidr)) . "/" . $Cidr);
             :set Branch [ $GetBranch $Address ];
             :set ($IPv6Addresses->$Branch->$Address) $TimeOut;
             :error true;