diff --git a/doc/mod/notification-email.md b/doc/mod/notification-email.md index 90254292..90f19815 100644 --- a/doc/mod/notification-email.md +++ b/doc/mod/notification-email.md @@ -37,8 +37,7 @@ Also make sure the device has correct time configured, best is to set up the ntp client. Then edit `global-config-overlay`, add `EmailGeneralTo` with a valid -recipient address. Optionally add `EmailServerCertificate` if you have -certificate verification enabled. Finally reload the configuration. +recipient address. Finally reload the configuration. > ℹ️ **Info**: Copy relevant configuration from > [`global-config`](../../global-config.rsc) (the one without `-overlay`) to diff --git a/global-config.rsc b/global-config.rsc index 43e09bbf..1425764c 100644 --- a/global-config.rsc +++ b/global-config.rsc @@ -31,7 +31,6 @@ :global EmailGeneralCc ""; #:global EmailGeneralTo "mail@example.com"; #:global EmailGeneralCc "another@example.com,third@example.com"; -:global EmailServerCertificate ""; # You can send Telegram notifications. Register a bot # and add the token and chat ids here, then install the module: diff --git a/global-functions.rsc b/global-functions.rsc index 0a8fdb77..d7f1aa70 100644 --- a/global-functions.rsc +++ b/global-functions.rsc @@ -109,13 +109,11 @@ :local UseFor [ :tostr $2 ]; :global CertificateDownload; + :global EitherOr; :global LogPrint; :global ParseKeyValueStore; - :if ([ :len $UseFor ] = 0) do={ - $LogPrint warning $0 ("The intended use is undefined!"); - :set UseFor "undefined"; - } + :set UseFor [ $EitherOr $UseFor "undefined" ]; :if ([ /system/resource/get free-hdd-space ] < 8388608 && \ [ /certificate/settings/get crl-download ] = true && \ @@ -188,11 +186,7 @@ $LogPrint warning $0 ("Failed downloading certificate with CommonName '" . $CommonName . \ "' from repository! Trying fallback to mkcert.org..."); :do { - :local CertSettings [ /certificate/settings/get ]; - :if ([ :len [ /certificate/find where common-name="ISRG Root X1" ] ] = 0 && \ - !((($CertSettings->"builtin-trust-store") ~ "fetch" || \ - ($CertSettings->"builtin-trust-store") = "all") && \ - [ :len [ /certificate/builtin/find where common-name="ISRG Root X1" ] ] > 0)) do={ + :if ([ :len [ /certificate/find where common-name="ISRG Root X1" ] ] = 0) do={ $LogPrint error $0 ("Required certificate is not available."); :return false; } diff --git a/mod/notification-email.rsc b/mod/notification-email.rsc index cd3ded9e..0955194d 100644 --- a/mod/notification-email.rsc +++ b/mod/notification-email.rsc @@ -37,9 +37,7 @@ # flush e-mail queue :set FlushEmailQueue do={ :onerror Err { :global EmailQueue; - :global EmailServerCertificate; - :global CertificateAvailable; :global EitherOr; :global EMailGenerateFrom; :global FileExists; @@ -92,14 +90,6 @@ :return false; } - :if ([ /tool/e-mail/get certificate-verification ] ~ "^yes" && \ - [ :len $EmailServerCertificate ] > 0) do={ - :if ([ $CertificateAvailable $EmailServerCertificate "email" ] = false) do={ - $LogPrint warning $0 ("Downloading required certificate failed."); - :return false; - } - } - /system/scheduler/set interval=($QueueLen . "m") comment="Sending..." \ [ find where name="_FlushEmailQueue" ];