groove/Part-DB-server
1
0
Fork 0
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2026-02-11 12:09:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Fixed phpstan issues in GenericWebProvider

Browse source
This commit is contained in:
Jan Böhmer 2026-02-07 17:07:53 +01:00
parent 851055bdb4
commit 061af28c48
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
phpstan.dist.neon
View file

@ -67,3 +67,6 @@ parameters:
- -
message: '#Should not use function "shell_exec"#' message: '#Should not use function "shell_exec"#'
path: src/Services/System/UpdateExecutor.php path: src/Services/System/UpdateExecutor.php
- message: '#Access to an undefined property Brick\\Schema\\Interfaces\\#'
path: src/Services/InfoProviderSystem/Providers/GenericWebProvider.php

9
src/Services/InfoProviderSystem/Providers/GenericWebProvider.php
View file

@ -213,14 +213,14 @@ class GenericWebProvider implements InfoProviderInterface
//Try to extract weight //Try to extract weight
$mass = null; $mass = null;
if (($weight = $product?->weight->getFirstValue()) instanceof QuantitativeValue) { if (($weight = $product->weight?->getFirstValue()) instanceof QuantitativeValue) {
$mass = $weight->value->toString(); $mass = $weight->value->toString();
} }
return new PartDetailDTO( return new PartDetailDTO(
provider_key: $this->getProviderKey(), provider_key: $this->getProviderKey(),
provider_id: $url, provider_id: $url,
name: $product->name?->toString() ?? $product->alternateName?->toString() ?? $product?->mpn->toString() ?? 'Unknown Name', name: $product->name?->toString() ?? $product->alternateName?->toString() ?? $product->mpn?->toString() ?? 'Unknown Name',
description: $this->getMetaContent($dom, 'og:description') ?? $this->getMetaContent($dom, 'description') ?? '', description: $this->getMetaContent($dom, 'og:description') ?? $this->getMetaContent($dom, 'description') ?? '',
category: $this->breadcrumbToCategory($categoryBreadcrumb) ?? $product->category?->toString(), category: $this->breadcrumbToCategory($categoryBreadcrumb) ?? $product->category?->toString(),
manufacturer: self::propertyOrString($product->manufacturer) ?? self::propertyOrString($product->brand), manufacturer: self::propertyOrString($product->manufacturer) ?? self::propertyOrString($product->brand),
@ -247,10 +247,7 @@ class GenericWebProvider implements InfoProviderInterface
return $value; return $value;
} }
if ($value instanceof Thing) { return $value->$property?->toString();
return $value->$property?->toString();
}
return null;
} }